Better error message on empty containers.

[maethu]

Currently it just displays a message, that the zip export ist not possible.

[shylux]

@maethu it was just this message right? i think the german and french translations fit.

[maethu]

@shylux Well, I guess event in german it translated with Der ausgewählte Inhalt unterstützt keinen Zip Export. But that's wrong the content supports zip export but I has No content with a zip representation.

I assume something like: Es konnte keine Zip-Datei erstellt werden, da kein Inhalt gefunden wurde, welcher als Zip-Datei exportiert werden kann.

[shylux]

https://github.com/4teamwork/ftw.zipexport/issues/14

Should i add this? It only happens when someone runs an older python version and tries to export over 4GB. I mentioned that also in the readme.

[deiferni]

@shylux i would include #14, a typical user will not read the README

[deiferni]

@shylux if i understand correctly ZipSelectedExportView is responsible for the folder_contents export (the user has to select what to export) whereas ZipExportView is responsible for the action_menu export (all exportable content is exported).

If this is correct, i think you could further improve usability by showing different error messages on ZipSelectedExportView and ZipExportView:

• The ZipSelectedExportView message could say that no exportable content was selected, since the user has to select content manually.
• The ZipExportView could say that no content has been found since it automatically discovers exportable content.

[shylux]

@deiferni @maethu updated

[deiferni]

@shylux you don't need to add a constructor if they only call the super implementation. Furthermore, if you accept any arguments you break the interface of BrowserView, e.g. as soon as somebody would use keyword arguments or more than two positional arguments you get TypeError: ... got an unexpected keyword argument https://github.com/4teamwork/ftw.zipexport/blob/lk_correct_error_message/ftw/zipexport/browser/zipexportview.py#L21 https://github.com/4teamwork/ftw.zipexport/blob/lk_correct_error_message/ftw/zipexport/browser/zipexportview.py#L86

[shylux]

@deiferni Removed the constructors.

[deiferni]

:sparkles: :+1: