Close data connection before 226 Reply

[GoogleCodeExporter]

rfc959 says in chapter 5.2.  CONNECTIONS:

..."To prevent a race condition here, the server
      sends a reply (226) after closing the data connection".

DTPHandler.handle_close works the other way round, it first sends the 226 
Reply, then closes the data connection.

>What steps will reproduce the problem?
1.Look at implementation,  
2. or make a wireshark of an uploadand inspect it

>What version of pyftpdlib are you using? On what operating system? >Which
>Python version?
pyftpdlib 0.5.2, but 0.6.0 has identical implementation.

Most ftp clients obviously have no problem with this implementation, but I have 
do deal with a ftp client in an embedded device that can't handle this. :(
It is easy to fix for me, but pyftpdlib should implement the rfc correctly.

Original issue reported on code.google.com by bernd.de...@gmail.com on 3 Mar 2011 at 6:22

[GoogleCodeExporter]

Thanks. The fix is not easy as it might seem though. I'll have to think about 
it carefully.

Original comment by g.rodola on 3 Mar 2011 at 7:43

[GoogleCodeExporter]

This should now be fixed in r837.
Please let me know if it solves your problem.

Original comment by g.rodola on 3 Mar 2011 at 8:10

• Changed state: Accepted
• Added labels: Milestone-0.6.1, RFC, Version-0.6.0

[GoogleCodeExporter]

Works fine, thanks!

Original comment by bernd.de...@gmail.com on 8 Mar 2011 at 10:03

[GoogleCodeExporter]

Original comment by g.rodola on 18 Mar 2011 at 10:43

• Changed state: FixedInSVN

[GoogleCodeExporter]

Original comment by g.rodola on 3 Jan 2012 at 11:40

• Added labels: Milestone-0.7.0

[GoogleCodeExporter]

0.7.0 is out. Closing this out as definitively fixed.

Original comment by g.rodola on 25 Jan 2012 at 7:24

• Changed state: Fixed