search

4uiiurz1 / pytorch-deform-conv-v2

PyTorch implementation of Deformable ConvNets v2 (Modulated Deformable Convolution)
MIT License
743 stars 141 forks source link

I think the weight should be initialized as 0 rather than 0.5 #10

Closed ToTheBeginning closed 5 years ago

ToTheBeginning commented 5 years ago

https://github.com/4uiiurz1/pytorch-deform-conv-v2/blob/9ccc492a37db946b57fe049d6f9f6ef54e8e6426/deform_conv_v2.py#L25

4uiiurz1 commented 5 years ago

In the paper, "Thus, the initial values of ∆pk and ∆mk are 0 and 0.5, respectively. "

ToTheBeginning commented 5 years ago

In the paper, "Thus, the initial values of ∆pk and ∆mk are 0 and 0.5, respectively. "

You may forget about the sigmoid :)

4uiiurz1 commented 5 years ago

I see. You are right. The modulated weight should be initialized as 0. Thanks for letting me know! i'll fix it!

jszgz commented 4 years ago

@ToTheBeginning Hello, can you review my issue ? I think the bilinear kernel is wrong