4uiiurz1 / pytorch-deform-conv-v2

PyTorch implementation of Deformable ConvNets v2 (Modulated Deformable Convolution)
MIT License
739 stars 141 forks source link

Confused with edge value. #3

Closed donnyyou closed 5 years ago

donnyyou commented 5 years ago

https://github.com/4uiiurz1/pytorch-deform-conv-v2/blob/918742a21cdad33ae73cad43ca7db4f14d1a8986/deform_conv_v2.py#L64

Why not the value of edge position in the padding area is not computed by bilinear interpolation, instead of sampling the floor-position value?

4uiiurz1 commented 5 years ago

I don't understand that problem well so can you explain it in detail?

donnyyou commented 5 years ago

Thanks for your reply! Why there is a floor operation for padding area?

4uiiurz1 commented 5 years ago

You are right. That code is unnecessary. Thanks for letting me know!