search

4xx / svg-edit

Automatically exported from code.google.com/p/svg-edit
MIT License
0 stars 0 forks source link

show/hide grid button sets "snap to grid" option but does not actually enable it #1221

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. start editor
2. click [show/hide grid] button
3. draw element, drawing is continuous
4. go into [document properties] and see that "snap to grid" is already checked
5. press [OK]
6. draw element, drawing now properly snaps to grid

What is the expected output? What do you see instead?

If [show/hide grid] also causes "snap to grid" to be checked in document 
properties, the setting should take effect immediately.

In what browser did you experience this problem? (ALL, Firefox, Opera, etc)

Chrome 35.0.1916.114 on OSX

In what version of SVG-edit does the problem occur? (Latest trunk, 2.5.1,
etc)

r1771/trunk

Please provide any additional information below.

Original issue reported on code.google.com by lindy...@gmail.com on 12 Jun 2014 at 5:19

GoogleCodeExporter commented 9 years ago 
Latest trunk does not have this issue as far as I can tell and r1771 isn't 
working at all for me.

You can confirm the latest trunk is working on 
http://svg-edit.googlecode.com/svn/trunk/editor/svg-editor.html . For future 
reference, please always test on latest trunk. Only the latest trunk, and for 
very critical issues, the previous stable release (at 
http://svg-edit.googlecode.com/svn/branches/stable/editor/svg-editor.html ) , 
have any support now.

And at least until any others join or resume support of the project, that 
support is mostly limited to those few areas which I happen to have already 
worked on myself--config/prefs, storage, exporting).

As an unrelated FYI, IIRC, previous versions did not properly support setting 
showGrid on load by config (which is now recommended to be done in a file you 
create yourself, "config.js", placed inside the "editor" folder), but you can 
now set a default boolean setting for showGrid (or gridSnapping for that 
matter, the setting which is shown in the Editor Options).

e.g.: svgEditor.setConfig({showGrid: true, gridSnapping: true});

Incidentally, do you think showGrid or gridSnapping should be made as a 
preference so its selection is remembered from session to session without need 
for config?

Original comment by bret...@gmail.com on 12 Jun 2014 at 9:39

GoogleCodeExporter commented 9 years ago 
Sorry, current trunk works (in that the [show/hide grid] button does not 
attempt to change the snap-to-grid preference. I'm not sure which old link I 
had followed to r1771.

In general I'd prefer grid show and grid snap to both be toggle buttons for 
easy access, as I tend to switch back and forth.

Original comment by lindy...@gmail.com on 12 Jun 2014 at 10:09

GoogleCodeExporter commented 9 years ago 
I see. But no desire to have that info be remembered upon reload of the SVG 
Editor instance? (Closing issue for now, but feel free to keep commenting or 
open another issue for your request.)

Original comment by bret...@gmail.com on 12 Jun 2014 at 10:13

GoogleCodeExporter commented 9 years ago 
No strong feelings about the preference option, but if everything in the editor 
options window was persistent across sessions that would make sense.

Original comment by lindy...@gmail.com on 12 Jun 2014 at 11:04

GoogleCodeExporter commented 9 years ago 
Yeah, I agree. I'm tied up with other work, but feel free to submit something 
if you like, issue or patch. But I think it would be better in this case, as 
you say, to have toggle buttons since it is probably not something to 
set-and-forget (maybe the same with the rulers).

Original comment by bret...@gmail.com on 12 Jun 2014 at 11:12