search

4xx / svg-edit

Automatically exported from code.google.com/p/svg-edit
MIT License
0 stars 0 forks source link

Patch for /trunk/editor/locale/lang.sl.js #1222

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Translated to Slovenian language by human. There are still some phrases to be 
translated - it will be easier while using.

Original issue reported on code.google.com by j...@freeapproved.com on 19 Jun 2014 at 2:31

Attachments:

GoogleCodeExporter commented 9 years ago 
Thank you very much--applied in trunk!

For future reference:
1. Check for changes to the locale file structure: 
https://code.google.com/p/svg-edit/source/browse/trunk/editor/locale/lang.sl.js 
(and you can of course look at the English locale to understand what any new or 
changed keys may mean). Sometimes keys need to be renamed (e.g., I changed 
export_png to export_img since the export is now for different kinds of images, 
not only PNG). I've updated the key back to the newer export_img from your 
patch, but the translation should be updated. There was also a change with 
there having been a mistake before with two "group" keys instead of "group" and 
"group_elements". It appears your text is ok for this, however, now that I 
reapplied the key change.
2. For the sake of simplifying the reading of patches, it's important to ensure 
consistency with whitespace. The project uses tabs for indentation, so don't 
add any indents (or let your editor add them) if they are based in spaces. 
There should also not be any combination of tabs and spaces next to each other.
3. It is important not to break the structure of the JavaScript: no removed or 
extra commas added, or text outside of the pair of surrounding quotation marks 
(if you need a quotation mark within the marks, it should be preceded by a \ 
(backslash)).

If these are too confusing, or if they would deter you from contributing, 
please don't worry, it is not too much trouble for me to fix them, but I 
thought I would let you know what can make the patch incorporation go more 
smoothly and possibly as a result more quickly.

Original comment by bret...@gmail.com on 22 Jun 2014 at 10:55

GoogleCodeExporter commented 9 years ago 
thank You for explaining.
I was actually not aware of those mistakes, even now I am not sure where I have 
added other whitespace than tabs. Of course I will pay attention to all your 
comments in the future.

How to include/make a translation of text in the other .js files, as 
"ext-markers"?
            {id: "start_marker_list", title: "Select start marker type" },
            {id: "mid_marker_list", title: "Select mid marker type" },
            {id: "end_marker_list", title: "Select end marker type" },
            {id: "nomarker", title: "No Marker" },
            {id: "leftarrow", title: "Left Arrow" },
            {id: "rightarrow", title: "Right Arrow" },
            {id: "textmarker", title: "Text Marker" },
            {id: "forwardslash", title: "Forward Slash" },
            {id: "reverseslash", title: "Reverse Slash" },
            {id: "verticalslash", title: "Vertical Slash" },
            {id: "box", title: "Box" },
            {id: "star", title: "Star" },
            {id: "xmark", title: "X" },
            {id: "triangle", title: "Triangle" },
            {id: "mcircle", title: "Circle" },
            {id: "leftarrow_o", title: "Open Left Arrow" },
            {id: "rightarrow_o", title: "Open Right Arrow" },
            {id: "box_o", title: "Open Box" },
            {id: "star_o", title: "Open Star" },
            {id: "triangle_o", title: "Open Triangle" },
            {id: "mcircle_o", title: "Open Circle" }

Original comment by j...@freeapproved.com on 23 Jun 2014 at 8:08