search

501st-alpha1 / big-gollum

A rails app that lets you make, browse, edit, and eventually control permission to gollum wikis.
MIT License
6 stars 2 forks source link

Update dependencies and fix resulting issues #28

Closed oponder closed 6 years ago

oponder commented 7 years ago

This updates various dependencies to try and avoid things getting too stale.

It also configures gollum to use the rugged adapter instead of the unmaintained grit adapter. The grit adapter was seemingly what was holding us back from going beyond ruby 1.9.3.

I ran into a error from rugged concerning a blank name and email, and resolved that after realising first name and last name were blank in my profile. So to avoid that I also added a presence validation for first name and last name, and added those fields to the first account sign up form.

WIP, some broken tests to fix because of the validation I introduced.

Related to: https://github.com/oponder/big-gollum/issues/23

oponder commented 7 years ago

@501st-alpha1 there was an open issue about letting big-gollum work on ruby versions greater than 1.9.3. Thought I'd take a crack at it.

Looks like I got things working. Not sure if this cause complications for the environment where you are currently running your installation though.

I tried bundle install on 1.9.3, and that no longer works smoothly, so this makes big-gollum only work on Ruby 2+ from the looks of it.

If your installation requires it to still work on 1.9.3, I can try and put in some conditional to switch between adapters based on the ruby version big-gollum detects it is running in. Let me know.

By the way, for the travis webhook I meant setting it up so that it would also report the result of the test run back in the PR, know what I mean?

501st-alpha1 commented 7 years ago

I'll review this when I get a chance. I'm pretty sure that my production instance will work with Ruby 2, but I'll confirm that as well.

For Travis CI you don't need to set up the webhook manually. Just log in with your GitHub account, and everything should be included in the OAuth scopes. From the Travis docs:

write:repo_hook

Building a new repository on Travis CI is as easy as enabling it in your profile and pushing a new commit.

Updating the webhook required for us to be notified from GitHub on new commits or pull requests requires this API scope. Additionally, your user needs to have admin access to the repository you want to enable.

I joined the Gitter chat, so if you have any other questions about Travis CI, feel free to hit me up there sometime tomorrow.