Library is not ready for production use

OleksandrKucherenko commented 8 years ago

Things that should be resolved:

library should be available over maven/jcenter repositories
library should be ready for including as a submodule into bigger projects:
- no hardcoded version of minsdk or targetsdk, or build tools. all those things should be defined over the variables, that is quite easy to override on root project;
- expected lower compatibility API (at least API 14)

If I find a free time I will create a fork and a pull request with those changes...

OleksandrKucherenko commented 7 years ago

Please apply two pull requests (in order they placed here):

As result you will get more ready for integration library than ever before. Enjoy!

After that I will be able to finally try SDK as a part of our integration project.

ripern commented 7 years ago

Have you gotten any response from Flic outside here or is this already solved? I was looking for a jcenter dependency.

Emill commented 7 years ago

The problem we had with bintray was that you couldn't select a custom license...

OleksandrKucherenko commented 7 years ago

Why do you need a custom license for a SDK?! if other companies like facebook, mixpanel, etc. is absolutely ok to publish own sdk with available licenses, why flip is so different?!

P.S. how i know you can simply include LICENSE file into project and it will become the "source of truth" for developer (it can be different to the license that maven repository is publishing)

OleksandrKucherenko commented 7 years ago

@ripern I publish artifact from my own fork in jcenter repository, so you can use my fork as a temporary solution, until the merge is complete.

OleksandrKucherenko commented 7 years ago

@Emill

I hope you saw that you can request a custom license in Web UI ?

ripern commented 7 years ago

Thanks @OleksandrKucherenko but I'm getting this error when referencing your fork: Error:Module 'io.flic:sdk:1.0.1.24' depends on one or more Android Libraries but is a jar Could it be that it references something not needed? (if so I could exclude it if you tell me what it might be). It would also be great if you could update to latest stable Android support versions, targetSdk 25 etc.

@Emill Perhaps it's possible today? What custom license is it that you want to use? It would be very useful for all developers if you could make it available somewhere online so we don't have to reference a lot of files locally as today. Thanks in advance! :)

Emill commented 7 years ago

The license shouldn't be added to bintray's public license list since it's only applicable to us.

This is the license: https://github.com/50ButtonsEach/fliclib-android/blob/master/LICENSE.txt

OleksandrKucherenko commented 7 years ago

@ripen you can try several tricks: 1) add prefix "@aar" at the end of the dependency declaration in gradle 2) exclude inner dependencies:

Example:

        androidTestCompile("com.android.support.test.espresso:espresso-core:${espressoVersion}", {
            exclude group: 'com.android.support', module: 'support-annotations'
            exclude group: 'com.google.code.findbugs', module: 'jsr305'
        })

I use the latest sdk/api/build tools in my "pull request". any way it should not be a problem to change the variables in gradle.properties to "shift" sdk to needed API level or support lib version.

ripern commented 7 years ago

@Emill Isn't there some other way you can solve the problem? I really don't wanna reference source code (via a module) as it is now.

@OleksandrKucherenko I added @aar and gradle sync works but I'm getting runtime errors when trying to access FlicManager. When referencing their source and importing a module everything works fine, but I rather only have a dependency like yours. Isn't there something more than just adding your dependency that is necessary?

OleksandrKucherenko commented 7 years ago

@ripern should work without any problems. You just need to confirm that binary attached to a correct configuration in gradle. Than check the dependencies:

./gradlew :app:dependencies

seanvia commented 7 years ago

👍 for this request. Waiting for this before integrating to my production use.

ripern commented 7 years ago

@Emill Isn't there some other way you can solve the problem? I really don't wanna reference source code (via a module) as it is now.

Haves1001 commented 7 years ago

Which worked for me (but does not really solve the problem with not having "real" version) was to use jitpack. Here you would find all information required to add the latest commit on github as a gradle dependency: https://jitpack.io/#50ButtonsEach/fliclib-android

50ButtonsEach / fliclib-android

Library is not ready for production use #11