512vincent / pdsh

Automatically exported from code.google.com/p/pdsh
GNU General Public License v2.0
0 stars 0 forks source link

genders module doesn't properly support query #1

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
See Debian bug here:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=594884

Original issue reported on code.google.com by mark.gro...@gmail.com on 7 Sep 2010 at 4:46

GoogleCodeExporter commented 8 years ago
I cannot yet reproduce this with pdsh-2.18 and genders-1.14:

grondo@hype137 ~/proj/pdsh-2.18/src/pdsh >nodeattr -q 'compute && nehalem' 
hype[144-153]
grondo@hype137 ~/proj/pdsh-2.18/src/pdsh >./pdsh -g 'compute&&nehalem' -q | 
tail -1
ehype[144-153]

Original comment by mark.gro...@gmail.com on 7 Sep 2010 at 5:22

GoogleCodeExporter commented 8 years ago
I may have jumped the gun reporting here. This is looking Debian specific.  
Feel free to close this bug.

Original comment by bpel...@gmail.com on 7 Sep 2010 at 8:37

GoogleCodeExporter commented 8 years ago
Ok, I was eventually able to reproduce on a debian squeeze system. However,
when I downloaded and installed pdsh-2.18 and built from source, the bug
went away.

We can reopen this issue if it appears that the problem is indeed in the pdsh
genders module.

Thanks
mark

Original comment by mark.gro...@gmail.com on 7 Sep 2010 at 9:39

GoogleCodeExporter commented 8 years ago
Brian,

I already was able to reproduce this issue on debian squeeze, so I continued to
look into it. As you've probably already found, the problem is that the genders
module is unable to dynamically resolve the "genders_query" symbol in "self", so
is falling back to genders_getnodes() (which doesn't support the query syntax).

I'm not sure why, but the version of ltdl.c used internally in pdsh seems to be
fine with lt_dlopen(NULL); lt_dlsym("genders_query"), whereas using the system
libltdl.so on debian squeeze, this fails.

If you instead use lt_dlopen("libgenders.so"); things seem to work again.
(Or you could rip out the dynamic detection of genders_query and just use
the symbol directly, I'm not exactly sure why it fails on debian libltdl.so)

I may update the upstream code to avoid the lt_dlopen(NULL). I'm not sure why
I did it in the first place. I guess to avoid an extra file open.

Original comment by mark.gro...@gmail.com on 7 Sep 2010 at 10:11

GoogleCodeExporter commented 8 years ago
Reopening this bug since dlopen(libgenders.so) isn't feasible
on systems that don't have libgenders-dev/devel packages installed.

pdsh should either remove backwards compatiblity for libgenders without
genders_query(), or should migrate to something that supports 
dlsym (RTLD_DEFAULT, "genders_query")

Original comment by mark.gro...@gmail.com on 29 Sep 2010 at 9:05

GoogleCodeExporter commented 8 years ago
This issue was closed by revision r1322.

Original comment by mark.gro...@gmail.com on 22 Apr 2011 at 2:32