search

51Degrees / Device-Detection

THE Fastest and most Accurate device detection for C / PHP / Perl / Python and Node.js - professionally maintained device data
https://51degrees.com/device-detection
Other
112 stars 46 forks source link

quick gcc 10 workaround #55

Closed gmm42 closed 2 years ago

gmm42 commented 3 years ago

GCC 10 now defaults to -fno-common which breaks compilation: https://gcc.gnu.org/gcc-10/porting_to.html

ghost commented 3 years ago

Hi @igzivkov!

Thank you for your message and your contribution. We will be processing this pull request soon.

Thanks again! Piotr

onovy commented 2 years ago

any progress? gcc-10 is still broken.

jwrosewell commented 2 years ago

Thank you for the reminder. This repository did not get tagged for follow up and the employee who previous responded has now left.

This will be looked at in the next few weeks.

jwrosewell commented 2 years ago

We are encouraging users to move to version 4 as this is the current version and supports changes to the web such as User Agent Client Hints.

Rather than accept this PR on a prior version we suggest the proposer forks the repository and applies the PR to the fork if they are not able to change to version 4. As such this PR will be closed.