51Degrees / common-cxx

A shared functionality library that is used by 51Degrees products
Other
0 stars 6 forks source link

enable strict mode for warnings (-Werror) in cmake and eliminate them #33

Closed justadreamer closed 10 months ago

justadreamer commented 11 months ago

There is a number of warnings detected when building through outside tools s.a. Xcode (that uses clang). To eliminate those, let's enable the strict mode for warnings through Cmake - similar to how it was done in https://github.com/51Degrees/device-detection-cxx/pull/60. Any warnings detected by compilers on corresponding runners (linux, windows, macos) - please fix as part of this issue too.