Don't download/unpack/include googletest when BUILD_TESTING is set to OFF

51Degrees / common-cxx

A shared functionality library that is used by 51Degrees products

Other

0 stars 6 forks source link

Don't download/unpack/include googletest when BUILD_TESTING is set to OFF #54

Closed kazuhiro closed 1 day ago

kazuhiro commented 3 weeks ago

Atm, googletest is downloaded, unpacked, and included even if tests are not going to be build because of BUILD_TESTING flag set to false. Would it be possible to skip googletest related steps as well?

Tracy51D commented 2 weeks ago

@kazuhiro - Thank you for reaching out. We will update you soonest.

Thanks Tracy

justadreamer commented 1 week ago

Hi @kazuhiro this has been addressed in the PR #55. Please let us know if the patch helps, or any further improvements you would like to add. Thank you for raising this.

Tracy51D commented 1 day ago

Hi @kazuhiro This issue has now been resolved. If you have any issues please feel free to re-open this ticket.

Thanks Tracy