search

51Degrees / data-issues

This repository is for reporting data issues with 51Degrees device detection
1 stars 0 forks source link

Twitter for Android Detection #2

Closed azaremba-adsterra closed 6 months ago

azaremba-adsterra commented 7 months ago

For the latest bases I found that there is a strange behaviour in detection of Twitter for Android (around from 28/29-04-2024). If send such hints - fodegrees detect as Chrome Mobile without Twitter for Android :( "User-Agent": "Mozilla/5.0 (Linux; Android 13; RMX3762 Build/TP1A.220624.014; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/122.0.6261.106 Mobile Safari/537.36 TwitterAndroid", "Sec-CH-UA": "\"Chromium\";v=\"122\", \"Not(A:Brand\";v=\"24\", \"Android WebView\";v=\"122\"", "Sec-CH-UA-Full-Version": "\"122.0.6261.106\"", "Sec-CH-UA-Full-Version-List": "\"Chromium\";v=\"122.0.6261.106\", \"Not(A:Brand\";v=\"24.0.0.0\", \"Android WebView\";v=\"122.0.6261.106\"", "Sec-CH-UA-Mobile": "?1", "Sec-CH-UA-Model": "\"RMX3762\"", "Sec-CH-UA-Platform": "\"Android\"", "Sec-CH-UA-Platform-Version": "\"13.0.0\"", But if you remove "Sec-CH-UA-Platform-Version" hint - it works!

Tracy51D commented 7 months ago

Hi there

We have done some testing on both the User-Agent as well as the User-Agent Client Hints. When you use the User-Agent only it does show ‘Twitter for Android’ correctly. When you use the User-Agent together with the Client Hints it also shows correctly. This is the case when ‘Sec-CH-UA-Platform-Version’ is excluded as well.

Below are links to our User-Agent tester page which shows the above: (apologies for the long links, GH seems to be playing up for me today)

Is this the only time you’ve seen this issue, or are there other instances of this that you’ve seen?

Thanks Tracy

barbiedrummer commented 7 months ago

Hi, @Tracy51D!

I've made some screenshots to save the results:

The main problem is detection of Twitter in general. When Twitter also sends CH-headers, the detection is less accurate compared to using only the UA-header.

The problem looks the same as described in https://github.com/51Degrees/device-detection-go/issues/9 (Facebook Browser)

Tracy51D commented 7 months ago

Thanks for providing screenshots. It looks like the detection has changed since I last sent the links on 4 April. It seems to be an algorithm problem, so would require engineering work on our side to investigate.

Thank you for raising this, I will speak with the relevant team.

Tracy

Tracy51D commented 6 months ago

Hi there,

In recent months we've been adjusting how we detect User-Agent Client Hint headers, and part of that work included tweaks to the Sec-CH-UA-Full-Version-List header. As you've spotted, further adjustment in the detection is needed.

We are currently modifying this in the data. As soon as this change has been completed, I will be back in touch to confirm that all is working correctly.

Thank you for your patience in this matter. Tracy

Tracy51D commented 6 months ago

Hi there,

This work has now been completed. I'm including the links to our User-Agent tester page for you to see:

Please can you confirm that this is now detecting correctly on your end.

Thanks Tracy

Tracy51D commented 6 months ago

Hi there,

As mentioned previously this issue has been fixed. As I've not heard back from you I will consider this issue resolved and close the issue. If you have any further issues please do reach out.

Thanks Tracy

barbiedrummer commented 5 months ago

Please can you confirm that this is now detecting correctly on your end.

@Tracy51D Thanks for solving the problem. Now everything works correctly.