search

51Degrees / device-detection-go

European Union Public License 1.2
0 stars 3 forks source link

Add Client Hints support #1

Closed krpn closed 2 years ago

krpn commented 3 years ago

Please add Client Hints support for Golang.

It's important because we can't detect Windows 11: https://docs.microsoft.com/en-us/microsoft-edge/web-platform/how-to-detect-win11

jwrosewell commented 2 years ago

We’re currently collecting feedback on Go features following the publication of an initial version with support for our V4 C code. The V4 C code supports UACH so it will be a case of exposing the additional functions to Go via CGO. The additional HTTP headers needed are added via fiftyoneDegreesResultsHashFromEvidence. You're welcome to add the necessary CGO code and tests and make a PR against this repo. Also if this is time critical for you then you could consider sponsoring the change. Please contact us if you'd like to follow this route.

jwrosewell commented 2 years ago

Further to the original issue concerning Microsoft's adoption of UACH. The draft report (not a draft specification or on track to become a specification) is still going through important changes with many issues outstanding. We have highlighted this to Microsoft.

tungntpham commented 2 years ago

Hi @krpn.

We have now released v4.3.2 with support for UACH. Please have a look at the example to see how to enable the UACH support.

Kind regards, Tung.