onpremise engine improvments - Githubissues

51Degrees / device-detection-go

European Union Public License 1.2

0 stars 3 forks source link

onpremise engine improvments #26

Closed iNetJoJo closed 6 months ago

iNetJoJo commented 6 months ago

features: options:

SetLicenceKey
SetProduct
SetMaxRetries default 0, infinity, added for easier testing
SetPollingInterval -> default to 30s methods
GetHttpHeaderKeys types: ErrLicenceKeyAndProductRequired ErrTooManyRetries

misc:
- WithDataUpdateUrl now throws error if url is not in valid format
- add more test cases
- in case
fixes:
- constructor was freezing if WithDataFile is provided without automatic data pulling
- calling Stop on engine would panic in case manager was not initated and c pointer was null
- Close channels on Stop
- md-5 compares compressed file

justadreamer commented 6 months ago

Please also make sure the tests pass so automation can merge this PR