51Degrees / device-detection-node

Device detection engines for Node.js implementation of the 51Degrees Pipeline API
Other
2 stars 4 forks source link

Fix/issue 148 #156

Closed AntonYPost closed 4 months ago

AntonYPost commented 4 months ago

Fixes issues for: https://github.com/51Degrees/device-detection-node/issues/148

It would also be more informative to log to the console more than just the Port that the service is being hosted to. Having the hostname or full url would be preferential.

The below error was produced after building and installing dependencies for Node On-Premise. I believe this is because there is no build for my environment.

justadreamer commented 4 months ago

@AntonYPost please do the

eslint . --ext .js

locally to identify and fix the linting errors that fail the build:

https://github.com/51Degrees/device-detection-node/actions/runs/9026281166/job/24803351454#step:5:393

Thanks