search

51Degrees / device-detection-php-onpremise

On-premise implementation of the 51Degrees Device Detection engines for the Pipeline API
Other
1 stars 3 forks source link

options.json: add PHP 7.2 #27

Closed pi-alexander-popel closed 10 months ago

justadreamer commented 11 months ago

Let's see how it builds - if it fails to build the bindings on macos for php 7.2 - we then exclude macOS from options.json

justadreamer commented 11 months ago

Some tests are failing for this PR :( It looks like some unsupported in PHP 7.2. function is being called in benchmark.php :( https://github.com/51Degrees/device-detection-php-onpremise/actions/runs/5933273845/job/16088476076#step:5:523 can we replace this function into something else: 

PHP Fatal error:  Uncaught Error: Call to undefined function hrtime() in /home/runner/work/device-detection-php-onpremise/device-detection-php-onpremise/common/device-detection-php-onpremise/performance-tests/benchmark.php:83
  Stack trace: