search

52ForPeerReview / gh-pages-template

GitHub Pages Template repository for 52 For Code Review challenge
https://52forpeerreview.github.io/gh-pages-template/
GNU Affero General Public License v3.0
0 stars 0 forks source link

Template repositories break Git Submodules #1

Open S0AndS0 opened 4 years ago

S0AndS0 commented 4 years ago

Describe the bug

When attempting to use this repository as a Template, the Git Submodules break. Example broken repository

To Reproduce

Click on the Use this template button, then clone the resulting repository.

Steps that did not resolve issue

I've attempted the following...

... but each fail to download/initialize Git Submodules.

I've attempted to copy configuration blocks from the working repository, eg...

gh-pages-template/.git/config

[submodule "collection-home"]
    url = https://github.com/liquid-utilities/collection-home.git
    active = true
[submodule "feed-atom"]
    url = https://github.com/liquid-utilities/feed-atom.git
    active = true
[submodule "feed-rss2"]
    url = https://github.com/liquid-utilities/feed-rss2.git
    active = true
[submodule "includes-translate"]
    url = https://github.com/liquid-utilities/includes-translate.git
    active = true

... to the broken repository, eg...

[submodule "collection-home"]
    url = https://github.com/liquid-utilities/collection-home.git
    active = true
[submodule "feed-atom"]
    url = https://github.com/liquid-utilities/feed-atom.git
    active = true
[submodule "feed-rss2"]
    url = https://github.com/liquid-utilities/feed-rss2.git
    active = true
[submodule "includes-translate"]
    url = https://github.com/liquid-utilities/includes-translate.git
    active = true

... and re-running the previous two command, however, this does not resolve the issue of Git Submodules failing to download/initialize.

Expected behavior

Cloning with --recurse-submodules option...

git clone --recurse-submodules git@github.com:52ForPeerReview/<account>.git

... should also setup Git Submodules.

Updating/upgrading submodules via...

git submodule update --init --merge --recursive

... or forcing remote downloads...

git submodule update --init --merge --recursive --remote

... should also setup Git Submodules. But these command do not do anything productive.

Additional context

An email has been sent to @GitHub with similar information that shows Template repositories break Git Submodules. Until a fix is made on their end likely a script will need to be written for those utilizing this repository as a Template.

spuder commented 2 years ago

I'm not able to reproduce. I created a github project template with a submodule. Cloning and creating new instances of the template appears to work correctly.

S0AndS0 commented 2 years ago

Interesting, perhaps it's been fixed. ... Though to clarify the steps; are ya forking the template via the GitHub Web-UI and then cloning the fork, or cloning the template to a separate directory?