implicit conversion double->qint32 on call of Box3D<double>::size(): Size

52North / IlwisCore

Integrated Land and Water Information System (ILWIS) is a remote sensing and GIS software. ILWIS Core is the functional center of ilwis4..

http://52north.org/communities/ilwis/

35 stars 13 forks source link

implicit conversion double->qint32 on call of Box3D<double>::size(): Size #25

Closed pokulo closed 10 years ago

pokulo commented 10 years ago

shouldn't a Box3D like an envelope of a coordinate system have a size handling doubles instead of integers?

This would imply the class Size also to be defined as template class.

MartinSchouwenburg commented 10 years ago

close this due to changes in the box

pokulo commented 10 years ago

the Issue remains in hox.h:line 120. Since xlength(), ylength() and zlength() all return a double, it seams handy, to also store it into a Size class, which preserves the values as double.

pokulo commented 10 years ago

fixed in https://github.com/52North/IlwisCore/commit/fd263f0661fb62a172aef29c6a6bedabaf1464da