search

52North / IlwisCore

Integrated Land and Water Information System (ILWIS) is a remote sensing and GIS software. ILWIS Core is the functional center of ilwis4..
http://52north.org/communities/ilwis/
34 stars 13 forks source link

Rename method #45

Open ridoo opened 10 years ago

ridoo commented 10 years ago

I think the setObject method could be better renamed to createProperty to better reflect what it does.

ridoo commented 10 years ago

To be honest it is unclear to me why an object created/set on the resource, prepared afterwards and its reference is returned. In GDALConnector the reference is being set explicitly afterwards as normal property ...

MartinSchouwenburg commented 10 years ago

It might create a property, or not. But no it can not be set directly. The function is at GdalConnector level and at that level you can not know if the caller wants to set the property (in this case) or wants to do something else withit. The purpose of the function is to create an IlwisObject from the info in the resource. What you want to do with the created object is upto the caller. In the two cases were it is used it sets idd a property.