52North / helgoland-toolbox

Collection of tools for a sensor observation based client
https://52north.github.io/helgoland-toolbox/
Other
13 stars 16 forks source link

extended-data-d3-timeseries-graph Check: additionalData can be null #111

Open ChrisMalewski opened 5 years ago

ChrisMalewski commented 5 years ago

Check: additionalData can be null

https://github.com/52North/helgoland-toolbox/blob/develop/projects/helgoland/d3/src/lib/extended-data-d3-timeseries-graph/extended-data-d3-timeseries-graph.component.ts : Line 99

ktsrivastava29 commented 1 year ago

I note that this issue was brought up long ago and has not been resolved. I want to work on this issue. Since there doesn't seem to be much activity at this repository, i'd like to know if it's still active. Is there another repository where all operations are carried out?

swapniljadhav96 commented 9 months ago

If additionalData can be null at line 99, you should guard against this possibility to avoid errors. You can add a null check before iterating over this.additionalData.