search

52North / helgoland-toolbox

Collection of tools for a sensor observation based client
https://52north.github.io/helgoland-toolbox/
Other
13 stars 16 forks source link

Open map selection by default #169

Closed ridoo closed 1 year ago

ridoo commented 1 year ago

In case of no selected datasets the map-selection view shall be opened by default. Seems that #167 introduced a regression (at least did not test and fix this behavior). However, the fix now ensures to return a valid Observable after validating a permalink even when parameters are available, so that map-selection will open even when no datasets are selected:

https://github.com/52North/helgoland-toolbox/blob/69c68eecc28216d960afdadd1460d50fe163faf3/projects/helgoland-timeseries/src/app/views/diagram-view/diagram-view.component.ts#L129-L133

ridoo commented 1 year ago

This PR contains changes which should not be part of the upstream project. Will re-open the PR after a cleanup