52North / sos4R

R client for the OGC Sensor Observation Service
https://52north.github.io/sos4R/
13 stars 13 forks source link

0.4 release timing and submission #131

Closed nuest closed 4 years ago

nuest commented 5 years ago

Due to CRAN policy (not too many releases in short time) and vacation we schedule the 0.4 happens end of year 2019.

@EHJ-52n and @nuest together go through the release checklist.

nuest commented 4 years ago

This concerns packages

[...] sos4R

which have one or more 'Additional issues' showing on their CRAN results pages (at the time of writing). Many of these are long-standing.

Please correct ASAP and before Jan 15 to safely retain the package on CRAN, bearing in mind the CRAN submissions shutdown from Dec 20 to Jan 6.

nuest commented 4 years ago

Working on the release now... fixing CHECK Notes and Warnings:

W  checking for missing documentation entries (731ms)
   Undocumented code objects:
     ‘WmlDefaultTVPMeasurementMetadata’ ‘WmlInterpolationType’
     ‘WmlMeasurementTVP’ ‘WmlMeasurementTimeseries’
     ‘WmlMeasurementTimeseriesMetadata’
     ‘as.data.frame.WmlMeasurmentTimeseries’ ‘fesDuringName’
     ‘fesNamespacePrefix’ ‘fesValueReferenceName’ ‘gmlGetReferencedNode’
     ‘gmlIsNodeReferenced’ ‘gmlResultTypeAttributeName’ ‘mimeTypeOM20’
     ‘parseWmlDefaultTVPMeasurementMetadata’ ‘parseWmlInterpolationType’
     ‘parseWmlMeasurementTVP’ ‘parseWmlMeasurementTimeseries’
     ‘parseWmlMeasurementTimeseriesMetadata’
     ‘sos200DefaultGetObsResponseFormat’ ‘sos200SpatialFilterName’
     ‘sos200TemporalFilterName’ ‘sosConvertFactor’ ‘sosConvertInteger’
     ‘sosIsListFieldAvailable’ ‘sosKVPParamNameNamespaces’
     ‘sosKVPParamNameSpatialFilter’ ‘sosKVPParamNameTemporalFilter’
     ‘sosTimeStamp’ ‘swe20DataArrayName’ ‘swe20Namespace’
     ‘swe20NamespacePrefix’ ‘switchSweNamespace’
     ‘wmlMeasurementTimeseriesName’
   Undocumented S4 classes:
     ‘WmlDefaultTVPMeasurementMetadata’ ‘WmlInterpolationType’
     ‘WmlMeasurementTimeseries’ ‘WmlTimeseries’ ‘SamsShapeOrNULL’
     ‘WmlMeasurementTimeseriesMetadata’ ‘WmlMeasurementTVP’
   Undocumented S4 methods:
     generic 'encodeRequestXML' and siglist 'SosGetObservation_2.0.0'
     generic 'getObservation' and siglist 'SOS_2.0.0,ANY'
     generic 'getObservation' and siglist 'SOS_2.0.0,list'
     generic 'phenomena' and siglist 'SOS_2.0.0'
     generic 'print' and siglist 'SweTextEncoding'
     generic 'show' and siglist 'SweTextEncoding'
     generic 'siteList' and siglist 'SOS_2.0.0'
     generic 'sites' and siglist 'SOS_2.0.0'
     generic 'sosCreateEventTime' and siglist 'GmlTimeObject'
     generic 'sosFeatureIds' and siglist 'WmlMonitoringPoint'
     generic 'sosFeaturesOfInterest' and siglist 'SOS_2.0.0'
     generic 'sosResult' and siglist 'WmlMeasurementTVP'
     generic 'sosResult' and siglist 'WmlMeasurementTimeseries'
     generic 'sosTime' and siglist 'SosObservationOffering_2.0.0'
     generic 'sosTime' and siglist 'WmlMeasurementTVP'
     generic 'sosUOM' and siglist 'WmlDefaultTVPMeasurementMetadata'
     generic 'toString' and siglist 'SweTextEncoding'
nuest commented 4 years ago
==> devtools::check(document = FALSE)

── Building ─────────────────────────────────────────────────────────────── sos4R ──
Setting env vars:
● CFLAGS    : -Wall -pedantic -fdiagnostics-color=always
● CXXFLAGS  : -Wall -pedantic -fdiagnostics-color=always
● CXX11FLAGS: -Wall -pedantic -fdiagnostics-color=always
────────────────────────────────────────────────────────────────────────────────────
✓  checking for file ‘/home/daniel/git/sos4R/DESCRIPTION’ ...
─  preparing ‘sos4R’:
✓  checking DESCRIPTION meta-information ...
─  installing the package to build vignettes
✓  creating vignettes (8m 52.1s)
─  checking for LF line-endings in source and make files and shell scripts
─  checking for empty or unneeded directories
   Removed empty directory ‘sos4R/.binder’
   Removed empty directory ‘sos4R/tests/testthat/cache’
─  building ‘sos4R_0.4.0.tar.gz’

── Checking ─────────────────────────────────────────────────────────────── sos4R ──
Setting env vars:
● _R_CHECK_CRAN_INCOMING_USE_ASPELL_: TRUE
● _R_CHECK_CRAN_INCOMING_REMOTE_    : FALSE
● _R_CHECK_CRAN_INCOMING_           : FALSE
● _R_CHECK_FORCE_SUGGESTS_          : FALSE
● NOT_CRAN                          : true
── R CMD check ─────────────────────────────────────────────────────────────────
─  using log directory ‘/home/daniel/git/sos4R.Rcheck’
─  using R version 3.6.2 (2019-12-12)
─  using platform: x86_64-pc-linux-gnu (64-bit)
─  using session charset: UTF-8
─  using options ‘--no-manual --as-cran’
✓  checking for file ‘sos4R/DESCRIPTION’
─  checking extension type ... Package
─  this is package ‘sos4R’ version ‘0.4.0’
─  package encoding: UTF-8
✓  checking package namespace information
✓  checking package dependencies (2.8s)
✓  checking if this is a source package ...
✓  checking if there is a namespace
✓  checking for executable files (1.1s)
✓  checking for hidden files and directories
✓  checking for portable file names ...
✓  checking for sufficient/correct file permissions
✓  checking serialization versions ...
✓  checking whether package ‘sos4R’ can be installed (12.5s)
✓  checking installed package size ...
✓  checking package directory ... OK
✓  checking for future file timestamps (1s)
✓  checking ‘build’ directory
✓  checking DESCRIPTION meta-information (494ms)
✓  checking top-level files ...
✓  checking for left-over files
✓  checking index information (417ms)
✓  checking package subdirectories (463ms)
✓  checking R files for non-ASCII characters ...
✓  checking R files for syntax errors ...
✓  checking whether the package can be loaded (1.1s)
✓  checking whether the package can be loaded with stated dependencies (554ms)
✓  checking whether the package can be unloaded cleanly (800ms)
✓  checking whether the namespace can be loaded with stated dependencies (782ms)
✓  checking whether the namespace can be unloaded cleanly (586ms)
✓  checking loading without being on the library search path (526ms)
✓  checking dependencies in R code (907ms)
✓  checking S3 generic/method consistency (1.3s)
✓  checking replacement functions (446ms)
✓  checking foreign function calls (946ms)
✓  checking R code for possible problems (12.7s)
✓  checking Rd files (551ms)
✓  checking Rd metadata ...
✓  checking Rd line widths ...
✓  checking Rd cross-references ...
✓  checking for missing documentation entries (586ms)
✓  checking for code/documentation mismatches (2.1s)
✓  checking Rd \usage sections (1.8s)
✓  checking Rd contents ...
✓  checking for unstated dependencies in examples ...
✓  checking sizes of PDF files under ‘inst/doc’ (1.2s)
✓  checking installed files from ‘inst/doc’ ...
✓  checking files in ‘vignettes’ ...
✓  checking examples (1m 19.2s)
   Examples with CPU or elapsed time > 5s
              user system elapsed
   siteList 47.556  0.097  66.404
✓  checking for unstated dependencies in ‘tests’ (438ms)
─  checking tests ...
✓  Running ‘testthat.R’ [67s/115s] (1m 55.5s)
✓  checking for unstated dependencies in vignettes (1m 55.8s)
✓  checking package vignettes in ‘inst/doc’ ...
✓  checking re-building of vignette outputs (9m 16.3s)
✓  checking for detritus in the temp directory

── R CMD check results ──────────────────────────────────────── sos4R 0.4.0 ────
Duration: 13m 20.5s

0 errors ✓ | 0 warnings ✓ | 0 notes ✓

R CMD check succeeded
nuest commented 4 years ago

WinBuilder looks good :point_down: for current and devel R

https://win-builder.r-project.org/M554w3K27R38/00check.log

* using log directory 'd:/RCompile/CRANguest/R-release/sos4R.Rcheck'
* using R version 3.6.3 (2020-02-29)
* using platform: x86_64-w64-mingw32 (64-bit)
* using session charset: ISO8859-1
* checking for file 'sos4R/DESCRIPTION' ... OK
* checking extension type ... Package
* this is package 'sos4R' version '0.4.0'
* package encoding: UTF-8
* checking CRAN incoming feasibility ... NOTE
Maintainer: 'Daniel Nuest <daniel.nuest@uni-muenster.de>'

New submission

Package was archived on CRAN

Possibly mis-spelled words in DESCRIPTION:
  Geospatial (37:10)
  OGC (3:19, 37:33)

CRAN repository db overrides:
  X-CRAN-Comment: Archived on 2020-01-16 as check issues were not
    corrected in time.

  'Additional issues'
* checking package namespace information ... OK
* checking package dependencies ... OK
* checking if this is a source package ... OK
* checking if there is a namespace ... OK
* checking for hidden files and directories ... OK
* checking for portable file names ... OK
* checking serialization versions ... OK
* checking whether package 'sos4R' can be installed ... OK
* checking installed package size ... OK
* checking package directory ... OK
* checking for future file timestamps ... OK
* checking 'build' directory ... OK
* checking DESCRIPTION meta-information ... OK
* checking top-level files ... OK
* checking for left-over files ... OK
* checking index information ... OK
* checking package subdirectories ... OK
* checking R files for non-ASCII characters ... OK
* checking R files for syntax errors ... OK
* loading checks for arch 'i386'
** checking whether the package can be loaded ... OK
** checking whether the package can be loaded with stated dependencies ... OK
** checking whether the package can be unloaded cleanly ... OK
** checking whether the namespace can be loaded with stated dependencies ... OK
** checking whether the namespace can be unloaded cleanly ... OK
** checking loading without being on the library search path ... OK
** checking use of S3 registration ... OK
* loading checks for arch 'x64'
** checking whether the package can be loaded ... OK
** checking whether the package can be loaded with stated dependencies ... OK
** checking whether the package can be unloaded cleanly ... OK
** checking whether the namespace can be loaded with stated dependencies ... OK
** checking whether the namespace can be unloaded cleanly ... OK
** checking loading without being on the library search path ... OK
** checking use of S3 registration ... OK
* checking dependencies in R code ... OK
* checking S3 generic/method consistency ... OK
* checking replacement functions ... OK
* checking foreign function calls ... OK
* checking R code for possible problems ... [24s] OK
* checking Rd files ... OK
* checking Rd metadata ... OK
* checking Rd line widths ... OK
* checking Rd cross-references ... OK
* checking for missing documentation entries ... OK
* checking for code/documentation mismatches ... OK
* checking Rd \usage sections ... OK
* checking Rd contents ... OK
* checking for unstated dependencies in examples ... OK
* checking sizes of PDF files under 'inst/doc' ... OK
* checking installed files from 'inst/doc' ... OK
* checking files in 'vignettes' ... OK
* checking examples ...
** running examples for arch 'i386' ... [17s] OK
** running examples for arch 'x64' ... [15s] OK
* checking for unstated dependencies in 'tests' ... OK
* checking tests ...
** running tests for arch 'i386' ... [58s] OK
  Running 'testthat.R' [57s]
** running tests for arch 'x64' ... [64s] OK
  Running 'testthat.R' [64s]
* checking for unstated dependencies in vignettes ... OK
* checking package vignettes in 'inst/doc' ... OK
* checking re-building of vignette outputs ... [419s] OK
* checking PDF version of manual ... OK
* checking for detritus in the temp directory ... OK
* DONE
Status: 1 NOTE

https://win-builder.r-project.org/8a53GDliTh76/00check.log

* using log directory 'd:/RCompile/CRANguest/R-devel/sos4R.Rcheck'
* using R version 4.0.0 RC (2020-04-21 r78276)
* using platform: x86_64-w64-mingw32 (64-bit)
* using session charset: ISO8859-1
* checking for file 'sos4R/DESCRIPTION' ... OK
* checking extension type ... Package
* this is package 'sos4R' version '0.4.0'
* package encoding: UTF-8
* checking CRAN incoming feasibility ... NOTE
Maintainer: 'Daniel Nuest <daniel.nuest@uni-muenster.de>'

New submission

Package was archived on CRAN

Possibly mis-spelled words in DESCRIPTION:
  Geospatial (37:10)
  OGC (3:19, 37:33)

CRAN repository db overrides:
  X-CRAN-Comment: Archived on 2020-01-16 as check issues were not
    corrected in time.

  'Additional issues'

Found the following (possibly) invalid file URIs:
  URI: sos4R-vignette-99-services.html
    From: inst/doc/sos4R-vignette-03-sos-operations.html
  URI: ../vignettes/sos4R-vignette-05-wrapper-functions.html
    From: NEWS.md
* checking package namespace information ... OK
* checking package dependencies ... OK
* checking if this is a source package ... OK
* checking if there is a namespace ... OK
* checking for hidden files and directories ... OK
* checking for portable file names ... OK
* checking serialization versions ... OK
* checking whether package 'sos4R' can be installed ... OK
* checking installed package size ... OK
* checking package directory ... OK
* checking for future file timestamps ... OK
* checking 'build' directory ... OK
* checking DESCRIPTION meta-information ... OK
* checking top-level files ... OK
* checking for left-over files ... OK
* checking index information ... OK
* checking package subdirectories ... OK
* checking R files for non-ASCII characters ... OK
* checking R files for syntax errors ... OK
* loading checks for arch 'i386'
** checking whether the package can be loaded ... OK
** checking whether the package can be loaded with stated dependencies ... OK
** checking whether the package can be unloaded cleanly ... OK
** checking whether the namespace can be loaded with stated dependencies ... OK
** checking whether the namespace can be unloaded cleanly ... OK
** checking loading without being on the library search path ... OK
** checking use of S3 registration ... OK
* loading checks for arch 'x64'
** checking whether the package can be loaded ... OK
** checking whether the package can be loaded with stated dependencies ... OK
** checking whether the package can be unloaded cleanly ... OK
** checking whether the namespace can be loaded with stated dependencies ... OK
** checking whether the namespace can be unloaded cleanly ... OK
** checking loading without being on the library search path ... OK
** checking use of S3 registration ... OK
* checking dependencies in R code ... OK
* checking S3 generic/method consistency ... OK
* checking replacement functions ... OK
* checking foreign function calls ... OK
* checking R code for possible problems ... [27s] OK
* checking Rd files ... OK
* checking Rd metadata ... OK
* checking Rd line widths ... OK
* checking Rd cross-references ... OK
* checking for missing documentation entries ... OK
* checking for code/documentation mismatches ... OK
* checking Rd \usage sections ... OK
* checking Rd contents ... OK
* checking for unstated dependencies in examples ... OK
* checking sizes of PDF files under 'inst/doc' ... OK
* checking installed files from 'inst/doc' ... OK
* checking files in 'vignettes' ... OK
* checking examples ...
** running examples for arch 'i386' ... [14s] OK
** running examples for arch 'x64' ... [15s] OK
* checking for unstated dependencies in 'tests' ... OK
* checking tests ...
** running tests for arch 'i386' ... [67s] OK
  Running 'testthat.R' [67s]
** running tests for arch 'x64' ... [72s] OK
  Running 'testthat.R' [71s]
* checking for unstated dependencies in vignettes ... OK
* checking package vignettes in 'inst/doc' ... OK
* checking re-building of vignette outputs ... [432s] OK
* checking PDF version of manual ... OK
* checking for detritus in the temp directory ... OK
* DONE
Status: 1 NOTE
nuest commented 4 years ago

On R-hub rgdal is only available for rhub/fedora-clang-devel but not for rhub/ubuntu-gcc-release

There the check succeeds: https://builder.r-hub.io/status/sos4R_0.4.0.tar.gz-6badaf445189469cae9aba7480bceb59


4954#> About to run xvfb-run R CMD check --as-cran sos4R_0.4.0.tar.gz

4955#> * using log directory ‘/home/docker/sos4R.Rcheck’

4956#> * using R Under development (unstable) (2020-04-18 r78254)

4957#> * using platform: x86_64-pc-linux-gnu (64-bit)

4958#> * using session charset: UTF-8

4959#> * using option ‘--as-cran’

4960#> * checking for file ‘sos4R/DESCRIPTION’ ... OK

4961#> * checking extension type ... Package

4962#> * this is package ‘sos4R’ version ‘0.4.0’

4963#> * package encoding: UTF-8

4964#> * checking CRAN incoming feasibility ... NOTE

4965#> Maintainer: ‘Daniel Nuest ’

4966#> New submission

4967#> Package was archived on CRAN

4968#> Possibly mis-spelled words in DESCRIPTION:

4969#> Geospatial (37:10)

4970#> OGC (3:19, 37:33)

4971#> CRAN repository db overrides:

4972#> X-CRAN-Comment: Archived on 2020-01-16 as check issues were not

4973#> corrected in time.

4974#> 'Additional issues'

4975#> * checking package namespace information ... OK

4976#> * checking package dependencies ... OK

4977#> * checking if this is a source package ... OK

4978#> * checking if there is a namespace ... OK

4979#> * checking for executable files ... OK

4980#> * checking for hidden files and directories ... OK

4981#> * checking for portable file names ... OK

4982#> * checking for sufficient/correct file permissions ... OK

4983#> * checking serialization versions ... OK

4984#> * checking whether package ‘sos4R’ can be installed ... OK

4985#> * checking installed package size ... OK

4986#> * checking package directory ... OK

4987#> * checking for future file timestamps ... OK

4988#> * checking ‘build’ directory ... OK

4989#> * checking DESCRIPTION meta-information ... OK

4990#> * checking top-level files ... OK

4991#> * checking for left-over files ... OK

4992#> * checking index information ... OK

4993#> * checking package subdirectories ... OK

4994#> * checking R files for non-ASCII characters ... OK

4995#> * checking R files for syntax errors ... OK

4996#> * checking whether the package can be loaded ... OK

4997#> * checking whether the package can be loaded with stated dependencies ... OK

4998#> * checking whether the package can be unloaded cleanly ... OK

4999#> * checking whether the namespace can be loaded with stated dependencies ... OK

5000#> * checking whether the namespace can be unloaded cleanly ... OK

5001#> * checking loading without being on the library search path ... OK

5002#> * checking use of S3 registration ... OK

5003#> * checking dependencies in R code ... OK

5004#> * checking S3 generic/method consistency ... OK

5005#> * checking replacement functions ... OK

5006#> * checking foreign function calls ... OK

5007#> * checking R code for possible problems ... OK

5008#> * checking Rd files ... OK

5009#> * checking Rd metadata ... OK

5010#> * checking Rd line widths ... OK

5011#> * checking Rd cross-references ... OK

5012#> * checking for missing documentation entries ... OK

5013#> * checking for code/documentation mismatches ... OK

5014#> * checking Rd \usage sections ... OK

5015#> * checking Rd contents ... OK

5016#> * checking for unstated dependencies in examples ... OK

5017#> * checking sizes of PDF files under ‘inst/doc’ ... OK

5018#> * checking installed files from ‘inst/doc’ ... OK

5019#> * checking files in ‘vignettes’ ... OK

5020#> * checking examples ... NOTE

5021#> Examples with CPU (user + system) or elapsed time > 5s

5022#> user system elapsed

5023#> Coercion 0.548 0.02 5.602

5024#> * checking for unstated dependencies in ‘tests’ ... OK

5025#> * checking tests ...

5026#> Running ‘testthat.R’ [33s/64s]

5027#> OK

5028#> * checking for unstated dependencies in vignettes ... OK

5029#> * checking package vignettes in ‘inst/doc’ ... OK

5030#> * checking re-building of vignette outputs ... OK

5031#> * checking PDF version of manual ... OK

5032#> * checking for non-standard things in the check directory ... OK

5033#> * checking for detritus in the temp directory ... OK

5034#> * DONE

5035#> Status: 2 NOTEs

5036#> See

5037#> ‘/home/docker/sos4R.Rcheck/00check.log’

5038#> for details.
nuest commented 4 years ago

image

The Travis checks have also completed!

nuest commented 4 years ago

https://github.com/52North/sos4R/pull/166

nuest commented 4 years ago

Submitted to CRAN:

[This was generated from CRAN.R-project.org/submit.html]

The following package was uploaded to CRAN:
===========================================

Package Information:
Package: sos4R 
Version: 0.4.0 
Title: Client for OGC Sensor Observation Services 
Author(s): Daniel Nuest [cre, aut] 
  (<https://orcid.org/0000-0002-0024-5046>), Edzer Pebesma [ctb] 
  (<https://orcid.org/0000-0001-8049-7069>), Ben Graeler [aut] 
  (<https://orcid.org/0000-0001-5443-4304>), Benjamin Pross 
  [aut], Eike Hinderk Juerrens [a 
Maintainer: Daniel Nuest <daniel.nuest@uni-muenster.de> 
Depends: R (>= 3.4.0) 
Suggests: readr, spacetime, leaflet, leafpop, mapdata, maps, maptools, 
  mapview, xts, testthat, rgdal, knitr, rmarkdown, webmockr, 
  kableExtra, skimr, clipr 
Description: A client for Sensor Observation Services (SOS, see 
  <https://www.opengeospatial.org/standards/sos>) as specified 
  by the Open Geospatial Consortium (OGC). With the package 
  users can retrieve (meta)data from SOS instances and 
  interactively create requests for near real-time observation 
  data based on the available sensors, phenomena, observations 
  etc. using thematic, temporal, and spatial filtering. 
License: GPL-2 
Imports: dplyr, httr, methods, parsedate, sp, stats, stringr, uuid, 
  xml2 (>= 1.2.2), 

The maintainer confirms that he or she 
has read and agrees to the CRAN policies.

Submitter's comment: # Test environments

* local R 3.6.2
* R-release, 
  R-devel, R-oldrel on Travis CI (Ubuntu 14.04 
  Trusty)
* Windows on Appveyor
* R-devel and R 3.6.3 
  on CircleCI (using rocker/geospatial image)
* R-Hub
* 
  win-builder (using devtools) for R-release and 
  R-devel

## R CMD check results

No errors.
No 
  warnings.
No notes.

## Other

This is a re-release 
  following a CRAN takedown earlier this year. The 
  package is only released now as new feature 
  implementations were pending. 

=================================================

Original content of DESCRIPTION file: 

Package: sos4R
Type: Package
Title: Client for OGC Sensor Observation Services
Version: 0.4.0
Date: 2020-04-22
Authors@R: 
  c(person(given = "Daniel",
           family = "Nuest",
           role = c("cre", "aut"),
           email = "daniel.nuest@uni-muenster.de",
           comment = c(ORCID = "0000-0002-0024-5046")),
    person(given = "Edzer",
           family = "Pebesma",
           role = "ctb",
           comment = c(ORCID = "0000-0001-8049-7069")),
    person(given = "Ben",
           family = "Graeler",
           role = "aut",
           comment = c(ORCID = "0000-0001-5443-4304")),
    person(given = "Benjamin",
           family = "Pross",
           role = "aut"),
    person(given = "Eike Hinderk",
           family = "Juerrens",
           role = "aut"),
    person(given = "52°North Initiative for Geospatial Open Source Software GmbH",
           email = "info@52north.org",
           role = "cph"))
Depends: R (>= 3.4.0)
Imports: dplyr, httr, methods, parsedate, sp, stats, stringr, uuid,
        xml2 (>= 1.2.2),
Suggests: readr, spacetime, leaflet, leafpop, mapdata, maps, maptools,
        mapview, xts, testthat, rgdal, knitr, rmarkdown, webmockr,
        kableExtra, skimr, clipr
Description: A client for Sensor Observation Services (SOS, see
    <https://www.opengeospatial.org/standards/sos>) as specified by the
    Open Geospatial Consortium (OGC). With the package users can
    retrieve (meta)data from SOS instances and interactively
    create requests for near real-time observation
    data based on the available sensors, phenomena, observations etc.
    using thematic, temporal, and spatial filtering.
License: GPL-2
URL: https://github.com/52North/sos4R
Encoding: UTF-8
LazyLoad: TRUE
ByteCompile: TRUE
BugReports: https://github.com/52North/sos4R/issues
VignetteBuilder: knitr
Collate: Constants.R caches.R R-Helper.R Class-OWS.R Class-GML.R
        Class-SWE.R Class-OM.R Class-SA.R Class-SAMS.R Class-WML_200.R
        Class-OM_20.R Class-OGC.R Class-SOS.R Class-SOS_100.R
        Class-SOS_200.R Class-SOS_200_GDA.R Class-SML.R
        Generic-methods.R OWS-methods.R OWS-methods-parsing.R
        SOS-methods-parsing.R OM-methods.R OM-methods-coercion.R
        OM-methods-parsing.R OM_20-methods-parsing.R OM_20-methods.R
        SA-methods.R GML-methods-util.R GML-methods.R
        GML-methods-coercion.R SWE-methods.R SML-methods.R
        GML-methods-parsing.R SWE-methods-parsing.R OGC-methods.R
        SOS-methods-accessor.R PrintShowStructureSummmary-methods.R
        SOS-methods-util.R SOS-methods.R SOS-methods-plotting.R
        SOS-methods-coercion.R SML-methods-util.R
        SML-methods-coercion.R SOS_200-methods-impl.R SOS_200-methods.R
        SOS_200-methods-parsing.R SOS_200_methods-gda.R
        WML_200-methods.R SAMS-methods.R Defaults.R Wrapper-methods.R
        Development.R
RoxygenNote: 7.1.0
Language: en-GB
NeedsCompilation: no
Packaged: 2020-04-23 07:42:08 UTC; daniel
Author: Daniel Nuest [cre, aut] (<https://orcid.org/0000-0002-0024-5046>),
  Edzer Pebesma [ctb] (<https://orcid.org/0000-0001-8049-7069>),
  Ben Graeler [aut] (<https://orcid.org/0000-0001-5443-4304>),
  Benjamin Pross [aut],
  Eike Hinderk Juerrens [aut],
  52°North Initiative for Geospatial Open Source Software GmbH [cph]
Maintainer: Daniel Nuest <daniel.nuest@uni-muenster.de>
nuest commented 4 years ago
> foghorn::cran_incoming(pkg = "sos4R")
# A tibble: 1 x 4
  package version cran_folder time               
  <chr>   <chr>   <fct>       <dttm>             
1 sos4R   0.4.0   pretest     2020-04-23 09:47:00
nuest commented 4 years ago

Dear maintainer,

package sos4R_0.4.0.tar.gz has been auto-processed and is pending a manual inspection of this new CRAN submission. A CRAN team member will typically respond to you within the next 10 working days. For technical reasons you may receive a second copy of this message when a team member triggers a new check.

Log dir: https://win-builder.r-project.org/incoming_pretest/sos4R_0.4.0_20200423_094715/ The files will be removed after roughly 7 days. Installation time in seconds: 52 Check time in seconds: 909 > 10 min R version 4.0.0 RC (2020-04-21 r78276)

Pretests results: Windows: https://win-builder.r-project.org/incoming_pretest/sos4R_0.4.0_20200423_094715/Windows/00check.log Status: 1 NOTE Debian: https://win-builder.r-project.org/incoming_pretest/sos4R_0.4.0_20200423_094715/Debian/00check.log Status: 1 NOTE

No strong reverse dependencies to be checked.

Best regards, CRAN teams' auto-check service

nuest commented 4 years ago

Thanks, we see on platforms without support for long doubles:

Still

test_check("sos4R") ── 1. Failure: can extract bbox from bounds of offering (@test_capabilities.R#24 toString(box) not equal to "-44.7159634789651, -171.370441435668, 67.972129750194, 142.92375463033". 1/1 mismatches x[1]: "-44.715963478965, -171.370441435668, 67.972129750194, 142.92375463033" y[1]: "-44.7159634789651, -171.370441435668, 67.972129750194, 142.92375463033"

--

Please fix and resubmit.

nuest commented 4 years ago

The above commit should have fixed things, but I've anyway submitted the "extensive" test variant to R-Hub, which will probably take a little while:


master* > rhub::check(platform = rhub::platforms()[,1]) ─ Building package ─ Uploading package ─ Preparing build, see status at https://builder.r-hub.io/status/sos4R_0.4.0.tar.gz-4e50cd36c70846059343841066ca4636 https://builder.r-hub.io/status/sos4R_0.4.0.tar.gz-49f9c784e6e14f6398ffcc90e30a113c https://builder.r-hub.io/status/sos4R_0.4.0.tar.gz-1535872e76004c32b2f5c965df5506c4 https://builder.r-hub.io/status/sos4R_0.4.0.tar.gz-06c8ce3693d54f04ae99183308a222a2 https://builder.r-hub.io/status/sos4R_0.4.0.tar.gz-452c46af8bee4676816d892c0e5fb75b https://builder.r-hub.io/status/sos4R_0.4.0.tar.gz-9869909912fe45fb8d4dcd2771e06985 https://builder.r-hub.io/status/sos4R_0.4.0.tar.gz-fd5afaed2d5c4f878455ddf4284efaba https://builder.r-hub.io/status/sos4R_0.4.0.tar.gz-2eff05f4a1904f42b27accdbdb3565f2 https://builder.r-hub.io/status/sos4R_0.4.0.tar.gz-6b04cea90fa549f2ab66c15dc71c9ee7 https://builder.r-hub.io/status/sos4R_0.4.0.tar.gz-39c0cb5baceb461b9fa92b88ce2a9f6c https://builder.r-hub.io/status/sos4R_0.4.0.tar.gz-7439cd12d6f24c81be714a149d09b7da https://builder.r-hub.io/status/sos4R_0.4.0.tar.gz-4b56198118704ab7b93af6797483d843 https://builder.r-hub.io/status/sos4R_0.4.0.tar.gz-534b79d8347a40db874ea56cb316f075 https://builder.r-hub.io/status/sos4R_0.4.0.tar.gz-4346f3e162ae4265954f48560087932d https://builder.r-hub.io/status/sos4R_0.4.0.tar.gz-317382a2cffc416ca116fc8969c6168c https://builder.r-hub.io/status/sos4R_0.4.0.tar.gz-52645cdf14d743d181ffdf1dbd65cb98 https://builder.r-hub.io/status/sos4R_0.4.0.tar.gz-59e25997d0954475a1d4ede6fe170b0d https://builder.r-hub.io/status/sos4R_0.4.0.tar.gz-132c6da884d6496abe9f98d85173649b https://builder.r-hub.io/status/sos4R_0.4.0.tar.gz-ffedaeb88649469082ceacd883951676 https://builder.r-hub.io/status/sos4R_0.4.0.tar.gz-3643e5ff583c4904ba7a70170a2855b6 ─ Build started


nuest commented 4 years ago

The above builds have a lot of PREPERRORs, which I don't know how to fix, and a few fail because of missing dependencies, which should on be an issue on CRAN.

Sending the resubmission now.

nuest commented 4 years ago
The following package was uploaded to CRAN:
===========================================

Package Information:
Package: sos4R 
Version: 0.4.0 
Title: Client for OGC Sensor Observation Services 
Author(s): Daniel Nuest [cre, aut] 
  (<https://orcid.org/0000-0002-0024-5046>), Edzer Pebesma [ctb] 
  (<https://orcid.org/0000-0001-8049-7069>), Ben Graeler [aut] 
  (<https://orcid.org/0000-0001-5443-4304>), Benjamin Pross 
  [aut], Eike Hinderk Juerrens [a 
Maintainer: Daniel Nuest <daniel.nuest@uni-muenster.de> 
Depends: R (>= 3.4.0) 
Suggests: readr, spacetime, leaflet, leafpop, mapdata, maps, maptools, 
  mapview, xts, testthat, rgdal, knitr, rmarkdown, webmockr, 
  kableExtra, skimr, clipr 
Description: A client for Sensor Observation Services (SOS, see 
  <https://www.opengeospatial.org/standards/sos>) as specified 
  by the Open Geospatial Consortium (OGC). With the package 
  users can retrieve (meta)data from SOS instances and 
  interactively create requests for near real-time observation 
  data based on the available sensors, phenomena, observations 
  etc. using thematic, temporal, and spatial filtering. 
License: GPL-2 
Imports: dplyr, httr, methods, parsedate, sp, stats, stringr, uuid, 
  xml2 (>= 1.2.2), 

The maintainer confirms that he or she 
has read and agrees to the CRAN policies.

Submitter's comment: # Test environments

* local R 3.6.2
* R-release, 
  R-devel, R-oldrel on Travis CI (Ubuntu 14.04 
  Trusty)
* Windows on Appveyor
* R-devel and R 3.6.3 
  on CircleCI (using rocker/geospatial image)
* R-Hub
* 
  win-builder (using devtools) for R-release and 
  R-devel

## R CMD check results

No errors.
No 
  warnings.
No notes.

## Other

Resubmission after 
  being informed about (i) invalid file URIs and (ii) 
  failures on platforms without support for long 
  doubles (both by Uwe Ligges).

This is a re-release 
  following a CRAN takedown earlier this year. The 
  package is only released now as new feature 
  implementations were pending. 

=================================================

Original content of DESCRIPTION file: 

[...]
nuest commented 4 years ago

https://cran.r-project.org/package=sos4R :tada:

(still lacking binaries etc.)

image

nuest commented 4 years ago

Release created: https://github.com/52North/sos4R/releases/tag/v0.4.0