search

52inc / Pulley

A library to imitate the iOS 10 Maps UI.
https://cocoapods.org/pods/Pulley
MIT License
2.02k stars 265 forks source link

Followed advice from #221, but resulted in Safe Area issue #298

Open schmorgledorf opened 5 years ago

schmorgledorf commented 5 years ago

Hi there —

Thanks so much for putting this project together - it has been super helpful. I've been playing around with putting a UI together that includes a pull down similar to what Issue 221 mentions - https://github.com/52inc/Pulley/issues/221

I have successfully implemented your advice but I am unable to resolve a Safe Area issue and wanted to ensure that my solution does not affect Pulley's math. For your reference I have attached a screenshot my manipulated version of the Example project that shows the safe area issue for iPhone X in the top navigation bar where there is overlap.

screen shot 2019-01-12 at 10 15 46 pm

Really appreciate all of the work you have put into this!

amyleecodes commented 5 years ago

You’ll need to account for the safe area in your view controller.

Depending on what you’re trying to accomplish, you may be better off putting in the “side” drawer mode and adjusting its width / insets to be full screen.