52inc / Pulley

A library to imitate the iOS 10 Maps UI.
https://cocoapods.org/pods/Pulley
MIT License
2.02k stars 265 forks source link

Enable .panel mode for iPhone SE #347

Closed gevartosky closed 4 years ago

gevartosky commented 5 years ago

Adding .compact to displayModeForCurrentLayout to enable .panel mode to iPhone SE.

Currently, if you rotate an iPhone SE to landscape mode, the panel takes a lot of space from the already small screen of the device, covering other buttons of the application.

amyleecodes commented 5 years ago

The default behavior Is meant to mimic the iOS maps app. Does the iOS maps app do this in landscape on an iPhone SE?

gevartosky commented 5 years ago

It actually gets smaller instead of going to .panel mode, but I'm not sure if there is a mode that fits this case. IMG_1546

ulmentflam commented 4 years ago

@gevartosky There is a mode that will fit this case now thanks to this PR! Checkout this branch and thanks for bringing up this issue! The next major version of Pulley will include support for the .compact displayMode and this displayMode when Pulley is.automatic for the iPhone SE size class devices.