52inc / Pulley

A library to imitate the iOS 10 Maps UI.
https://cocoapods.org/pods/Pulley
MIT License
2.02k stars 265 forks source link

Crashing due to loop of broken constraints when changing drawer content VC? #375

Open jackjpark opened 4 years ago

jackjpark commented 4 years ago

I was using a much older version of the drawer but needed the support for the iPhone X and above, im having an issue where now when i change the content VC of the drawer, the second VC set causes a never ending loop of layout constraint breaking which will crash the app

It worked fine in the older version of the drawer and my initial drawer VC works fine, its just when its changed

Is there a way i can debug this as there are so many errors in the loop i have no idea where to start?

Thanks

theogscott commented 3 years ago

I seem to have a problem with an app that worked perfectly in November 2019, but now no longer working and going to an infinite loop, until the device runs out of memory and then crashes.

This is what I know: PulleyViewController keeps on dispatching viewDidLayoutSubViews() in the main thread, the app completes UIViewController.viewDidLoad()for controller that needs to display, but never gets to UIViewController.viewDidAppear().

ulmentflam commented 3 years ago

@theogscott Have you taken a look at issue #390, and updated Pulley since the release of iOS 14? Unfortunately iOS 14 created some autolayout feedback loops issues that are fixed in release 2.8.5 and above.

theogscott commented 3 years ago

@ulmentflam Thanks that helped a lot.

Roman-swift commented 3 years ago

@ulmentflam I have it problem now (only on iphone 11 pro, 11 pro max, 12 pro/ iOS 14.4). Pulley version 2.9.0, xCode version 12.4. It works good on other devices. This is what I know: When i don't send ".open" in func supportedDrawerPositions () -> [PulleyPosition] - no bug. DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) fixed it, but not everything works correctly. Please, help me

theogscott commented 3 years ago

@Roman-swift I'm using v 2.9.0, Xcode Version 12.4 (12D4e) and for me it works on iPhone 6s, 7+, 11 - iOS 14.5 I did noted in the console some complains about constraint issues when running the app, but not had a good look at the problem in detail.