52inc / Pulley

A library to imitate the iOS 10 Maps UI.
https://cocoapods.org/pods/Pulley
MIT License
2.02k stars 265 forks source link

Fix the bouncy drawer bug on iPad and Mac #407

Closed HassanElDesouky closed 3 years ago

HassanElDesouky commented 3 years ago

Description

I'm currently using Pulley for a project that contains a UISplitViewController, I found out that when I open a view controller that has Pulley in it, it does that bouncy effect. I tried to fix the issue and it worked for me, so I thought I should open a PR. :)

Here's a short video for the bug: https://youtu.be/h_ztzbAuBjw

Fixes: The bouncy drawer bug on iPad and Mac

Type of change

How Has This Been Tested?

Please describe the tests that you performed to verify your changes. Provide instructions so we can reproduce. Please provide details on how you tested supported versions of iOS and Xcode. Please make sure you have tested on all device size classes and orientations. Please also list any relevant details for your test configuration

Test Configuration

Checklist:

ulmentflam commented 3 years ago

@HassanElDesouky Thanks for the contribution! I have merged this into master for testing!