fix: panel mode closed state has visible drawer part

[MarkKazakov]

Description

When using pulley in panel display mode, in closed position the drawer is still visible because of the bounceOverflowMargin that is added to drawer's height in panel mode.

By removing bounceOverflowMargin from the height calculation in syncDrawerContentViewSizeToMatchScrollPositionForSideDisplayMode This is no longer an issue

Fixes # (issue) https://github.com/52inc/Pulley/issues/409

Type of change

• [ ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

To reproduce the issue call setDrawerPosition with .closed in panel mode. Expected result - no visible drawer Actual result - part of the drawer is visible with height equal to bounceOverflowMargin

With the fix only panel mode is affected and the drawer is hidden as expected in .closed position

• [ ] Test iOS 14
• [ ] Test iOS 13

Checklist:

• [ ] My code follows the style guidelines of this project
• [ ] My code does not break backwards compatibility with earlier versions of PulleyLib
• [ ] My code is fully functional with all supported device sizes and orientations
• [ ] I have performed a self-review of my own code
• [ ] I have checked that my code does not break the behavior of the Sample/Demo app
• [ ] My changes generate no new warnings
• [ ] I have tested and can prove my fix is effective or that my feature works

[iGeX]

I've expirenced another panel mode bug in my converted Xamarin project, maybe it reproduces also in original project. When I applied your fix, overlapping part has gone, but when drawer position changes it still has some twitchy animation in the end (jumping some amount of pixels down and backwards), I suppose it is also related to bouncingOverlowMargin.

[ulmentflam]

@iGeX and @MarkKazakov I made an alternate fix on this branch. Let me know if that fixes the issues with the twitchy animation when the drawer position changes.