52inc / Pulley

A library to imitate the iOS 10 Maps UI.
https://cocoapods.org/pods/Pulley
MIT License
2.02k stars 265 forks source link

Use animationDuration for transition animation duration #411

Closed ChaosCoder closed 3 years ago

ChaosCoder commented 3 years ago

Description

This uses the already existing animationDuration to animate when a primary or drawer view controller changes instead of hardcoding it to 0.5.

This alters the behavior, as the default animationDuration is set to 0.3, but the hardcoded value was set to 0.5. As this is only a cosmetic change, I would argue that it does not break previous behavior.

If you would like to introduce a new property for it instead of reusing the (then poorly named) animationDuration, I would be happy to get name suggestions.

Type of change

Checklist: