52inc / Pulley

A library to imitate the iOS 10 Maps UI.
https://cocoapods.org/pods/Pulley
MIT License
2.02k stars 265 forks source link

remove bounce overflow margin substract for panel #417

Closed ngerdzhikov closed 3 years ago

ngerdzhikov commented 3 years ago

Description

This PR addresses an issue described here. There is a redundant subtraction from the frame of the drawerContentView with the bounceOverflowMargin var when it's displayed for .panel and .compact modes where bouncing is disabled.

Fixes # 416

Type of change

How Has This Been Tested?

Verified that the issue is fixed by inspecting the UI with XCode on iPad Simulator for panel and compact display modes. The change doesn't affect drawer mode so It's not tested in drawer mode. In the linked issue there is provided explanation on how to reproduce the issue this pull request fixes.

This code is probably a copy paste issue in the first place.

Test Configuration

Checklist:

tougher commented 3 years ago

This fix unfortunately makes too much padding in the top. image