5G-MAG / Standards

Specifications related to 5G-MAG's areas of work. Tracking comments, bug-fixing, request for new features, etc.
https://www.5g-mag.com/standards
11 stars 2 forks source link

TS 26.512: M1 ConsumptionReportingConfiguration.reportingInterval value range not present in the OpenAPI YAML #96

Closed davidjwbbc closed 4 months ago

davidjwbbc commented 9 months ago

Description

In TS 26.512, Table 7.7.3.1-1 says that the reportingInterval, if present, shall be greater than zero. However this limitation is not specified in the YAML OpenAPI description in Annex C.3.6.

This limitation should be included in the OpenAPI YAML for the ConsumptionReportingConfiguration schema.

Suggested solution

Change the end of the YAML in Annex C.3.6 from

components:
  schemas:
    ConsumptionReportingConfiguration:
      type: object
      description: "A representation of a Consumption Reporting Configuration resource."
      properties:
        reportingInterval:
          $ref: 'TS29571_CommonData.yaml#/components/schemas/DurationSec'
        samplePercentage:
          $ref: 'TS26512_CommonData.yaml#/components/schemas/Percentage'
        locationReporting:
          type: boolean
        accessReporting:
          type: boolean

to

components:
  schemas:
    ConsumptionReportingConfiguration:
      type: object
      description: "A representation of a Consumption Reporting Configuration resource."
      properties:
        reportingInterval:
          minimum: 0
          exclusiveMinimum: true
          allOf:
            - $ref: 'TS29571_CommonData.yaml#/components/schemas/DurationSec'
        samplePercentage:
          $ref: 'TS26512_CommonData.yaml#/components/schemas/Percentage'
        locationReporting:
          type: boolean
        accessReporting:
          type: boolean

Additional context

This issue based on TS 26.512 v17.6.0

rjb1000 commented 9 months ago

@davidjwbbc: Have you verified that the suggested solution is workable with the OpenAPI Generator templates?

rjb1000 commented 8 months ago

Change Request addressing this issue endorsed during yesterday's 3GPP SA4 ad hoc call:

Revisions to be contributed to SA4#126 (Chicago).

rjb1000 commented 7 months ago

Change Requests agreed at SA4#126 (Chicago):

Added bounds checking to OpenAPI YAML definition of reportingInterval parameter in clause C.3.6.

rjb1000 commented 4 months ago

CR Packs approved at SA#102 (Edinburgh):

rjb1000 commented 4 months ago