search

5HT2B / heartbeat-unix

The heartbeat client for Linux, macOS and Unix
ISC License
2 stars 1 forks source link

bunch of fixes (can't think of a better title, feel free to edit) #6

Closed lmaotrigine closed 1 year ago

lmaotrigine commented 1 year ago

the plist invokes the script with /bin/sh -c, which (afaik) is a symlink to zsh on Macs produced in the last half a decade at least, so change the shebang and the [[ ]]s.

Also on an unrelated note, why the inconsistency in the env file naming (~/.env vs. ~/.heartbeat)?

EDIT: I forgot I already opened a PR with this branch as the base, so the scope of this has increased a bit.

This PR now also allows for configuring the process name of the screen locker which is the simplest way of supporting various configurations of this. The docs also note the lack of Wayland support.

It also ensures that the log directory is created before writing to a file inside it.

5HT2 commented 1 year ago

Also on an unrelated note, why the inconsistency in the env file naming (~/.env vs. ~/.heartbeat)?

Ah well that would be because of #1 and I never realized! Nice catch.

5HT2 commented 1 year ago

ty for the fixes<3 these look great!