Additions and suggestions

juniorcaesar commented 1 year ago

first of all, thank you so much for your guide! it is very helpful and comprehensive. however, some bits are ambiguous in the guide:

first, in Part IV, Node 24 is labeled as "(Jack) Mic at Ext Left" and Node 25 is labeled as "Speaker Ext. (S) IN Detect" in the final routings table.
In Part V, Node 24 is used as Line In of the docking station but in Part IX (in your patched pin-config) you highlighted Node 25 as the Line In of the dock.

If the Node 24 is the combojack that exists on the laptop itself, shouldn't it be placed with the Node 18 (internal mic) in order to get automatic switching working (in the Part VII, on the "finished Platforms39.xml" screenshot)? I didn't understand why you put the Line In of the dock (25) under the Node 18 since you stated that you need to switch manually in order to get microphones working without sending the sound through the input jack.

I'm sorry if i got this wrong but labeling the jacks according to their physical locations would be nice in the Part IV in order to clear any confusions down the guide.

second, the MuteGPIO section doesn't explain what you need to do when there is no VREF value on the Internal Microphones and you add manual switch to the Line-In; you shouldn't add any MuteGPIO value under the "Mic" dictionary since it can't be muted. you need to, however, add the MuteGPIO values to the "LineIn" directory in order to get sound from headphones with four pole jacks.

now, i want to suggest a tip for what to do when the codec dump does not have clear labels on the nodes. i struggled to figure out what node is the Line-In for the combojack because nearly half of the nodes are labeled as "Speaker" and they have the Pin-configs of "0x411111f0".

microphone of my EarPods work without a problem in linux, so i installed "alsa-tools" and used hdajacksensetest to see which nodes change when i plug in my headset. as you can see, Node 19 is the Line-In for the combojack, but it has specific properties attached to it (Pink Mic, Right Side), unlike "Black Speaker" in my codec-dump. i found out that it was patched in the linux kernel. to confirm that, i did navigate to "/sys/class/sound/hwC0D0. in here, a specific text file took my interest named driver_pin_configs. sure enough, it was the pin-config that was applied when i boot into linux. i used that pin-config to correct my Line-In node and it is now working properly. in the case that the microphones / speakers / etc. do not work in the linux, you can get the codec dump from windows with this tool to see the replaced pin-configs.

inclusion of this information might be useful for the people who have the same problem as mine. this guide was very helpful and the credits goes to them.

5T33Z0 commented 1 year ago

Merry Christmas! Thanks for your feedback, detailed notes and suggestions! I will have a look at all of this in the new year and update the guide accordingly.

juniorcaesar commented 1 year ago

Merry Christmas to you too! i forgot to add one more thing in my feedback; in Part V (creating a PathMap), it is mentioned that in Manual Switching, you need to set the type of the third "0" sub folder as "Dictionary". however, when set my manual-switch Line In path like that, it doesn't show up in the system settings so i need to set the third "0" sub folder as "Array", like the Auto-Switching mode.

i took a look at your Platforms39.xml and you also did the same thing. in what cases you need to apply the manual switching?

thanks again, and happy new year!

5T33Z0 commented 1 year ago

Thanks. Manual switching the line in input is useful if you have a headphone with a build-in mic but you want to use a separate mic of better quality attached to the line-in instead for example.

In all my attempts to implement audio being passed through to the docking station I am using, this was the only way switching back and forth between the dock and the combo jack on the notebook worked for me.

flo-at-work commented 6 months ago

Hello,

I don't know where to post this, so I post it here instead of creating something else. I followed the guide here: https://github.com/5T33Z0/AppleALC-Guides/tree/main/Codec_Dumps to create the codec dump for ALC292 from ThinkPad X250 so you can add it to the repository for reference. The files can be downloaded here: https://mab.to/t/fFdgQ6KCj0O/eu1 Please note that it just the basic dump and I didn't patched them yet.

Thanks

5T33Z0 commented 6 months ago

Hello,

I don't know where to post this, so I post it here instead of creating something else. I followed the guide here: https://github.com/5T33Z0/AppleALC-Guides/tree/main/Codec_Dumps to create the codec dump for ALC292 from ThinkPad X250 so you can add it to the repository for reference. The files can be downloaded here: https://mab.to/t/fFdgQ6KCj0O/eu1 Please note that it just the basic dump and I didn't patched them yet.

Thanks

Thanks for sharing. I've added your CODEC dump to the repo.

5T33Z0 / AppleALC-Guides

Additions and suggestions #2