search

5T33Z0 / OC-Little-Translated

ACPI Hotpatches and Guides for the OpenCore Bootmanager. Enhance and fine-tune your Hackintosh by adding devices and enabling additional features not covered in the OpenCore Install Guide. Only place that covers how to use OpenCore Legacy Patcher on PCs.
BSD 3-Clause "New" or "Revised" License
524 stars 71 forks source link

Remove DTGP method reference #53

Closed dreamwhite closed 1 year ago

dreamwhite commented 1 year ago

DTGP method is not needed. e.g. on SSDT-PLUG had DTGP method but no improvement had been discovered. This PR removes DTGP method from SSDT-RX580

5T33Z0 commented 1 year ago

How do you know that? Just because it isn't needed for one device doesn't mean it is irrelevant for another one.

No merge until further proof.

dreamwhite commented 1 year ago

It's actually a dead code. https://github.com/acidanthera/OpenCorePkg/commit/521196baabd991a4f6b337a1c2f70c26ca252f32

5T33Z0 commented 1 year ago

Well, it was removed SBUS-MCHC Table because the method wasn't used in this table. But Local0 is used in SSDT-Rx580.

dreamwhite commented 1 year ago

Well, on SSDT-PLUG DTGP method was used but then removed: https://github.com/acidanthera/OpenCorePkg/blob/f6b4ac59be255a5592ce0aad6e849a1e5b6a7ccb/Docs/AcpiSamples/SSDT-PLUG.dsl

5T33Z0 commented 1 year ago

But the method was not just removed, the whole table was re-written in this case. @Baio1977 Can you have a look at the SSDT-RX580 table and check if it's okay, to simple delete the DTGP method fand references from it? Thanks.

Baio1977 commented 1 year ago

Check this PR https://github.com/5T33Z0/OC-Little-Translated/pull/53/commits/e36bc2ac3c72a64e2b296b40ed2ba0e4ee06e8d7