search

5T33Z0 / OC-Little-Translated

ACPI Hotpatches and Guides for the OpenCore Bootmanager. Enhance and fine-tune your Hackintosh by adding devices and enabling additional features not covered in the OpenCore Install Guide. Only place that covers how to use OpenCore Legacy Patcher on PCs.
BSD 3-Clause "New" or "Revised" License
547 stars 73 forks source link

SSDT ERROR #56

Closed Baio1977 closed 2 years ago

Baio1977 commented 2 years ago

https://github.com/5T33Z0/OC-Little-Translated/blob/main/04_Fixing_Sleep_and_Wake_Issues/060D_Instant_Wake_Fix/i_Common_060D_Patch/SSDT-XPRW.dsl

""" If (_OSI ("Darwin")){ """

it must stand after the Method in this case.

Use standard GPRW or UPRW SSDT.

SSDT-GPRW.dsl.zip

SSDT-UPRW.dsl.zip

Baio1977 commented 2 years ago

https://github.com/5T33Z0/OC-Little-Translated/blob/main/04_Fixing_Sleep_and_Wake_Issues/060D_Instant_Wake_Fix/i_Common_060D_Patch/SSDT-PRW0.dsl.

SSDT-PRW0 correction

Screenshot 2022-10-02 alle 09 20 25

Added

"" " Scope ( \ ) "" "

5T33Z0 commented 2 years ago

Thanks, I'll add the scope. It has been working fine without it on my Laptop for months now, though.

5T33Z0 commented 2 years ago

https://github.com/5T33Z0/OC-Little-Translated/blob/main/04_Fixing_Sleep_and_Wake_Issues/060D_Instant_Wake_Fix/i_Common_060D_Patch/SSDT-XPRW.dsl

""" If (_OSI ("Darwin")){ """

it must stand after the Method in this case.

Use standard GPRW or UPRW SSDT.

SSDT-GPRW.dsl.zip

SSDT-UPRW.dsl.zip

Do you mean, like this:

DefinitionBlock("", "SSDT", 2, "5T33Z0", "XPRW", 0)
{
    External (XPRW, MethodObj)

Method (GPRW, 2)
    {
        If (_OSI ("Darwin"))
        {
            If (0x6d == Arg0) { Return (Package() { 0x6d, 0, }) }
            If (0x0d == Arg0) { Return (Package() { 0x0d, 0, }) }
            Return (XPRW (Arg0, Arg1))
        }

Method (UPRW, 2)
    {
        If (_OSI ("Darwin"))
        {
            If (0x6d == Arg0) { Return (Package() { 0x6d, 0, }) }
            If (0x0d == Arg0) { Return (Package() { 0x0d, 0, }) }
            Return (XPRW (Arg0, Arg1))
        }
    }
  }
}
Baio1977 commented 2 years ago

Thanks, I'll add the scope. It has been working fine without it on my Laptop for months now, though.

That you say is correct, see example SSDT-XOSI does not have Scope, so it is automatically inserted under ( \ ), which is the primary Scope.

5T33Z0 commented 2 years ago

So I have changed it for no reason now…

After the changes in SSDT-XPRW I get a warning now: "Not all Control paths return a value":

Bildschirmfoto 2022-10-02 um 10 07 46

Is that a problem?

Baio1977 commented 2 years ago

Use this file , do not change this is already okay, the 2 SSDTs are independent it is right to make them available individually SSDT-GPRW.dsl.zip SSDT-UPRW.dsl.zip