search

5T33Z0 / OC-Little-Translated

ACPI Hotpatches and Guides for the OpenCore Bootmanager. Enhance and fine-tune your system by adding devices and enabling additional features not covered in the OpenCore Install Guide.
BSD 3-Clause "New" or "Revised" License
504 stars 71 forks source link

Update laptop kexts order #72

Closed bytecntrl closed 1 year ago

bytecntrl commented 1 year ago

I all kept your kexts, i just added the MinKernels that were missing! The only kext I added is SMCLightSensor.kext (not specific to HP).

5T33Z0 commented 1 year ago
  1. I don't like most of the comments you changed. The comment field is meant for short but concise descriptions of what a kext does. And a comment like "Allows reading Embedded Controller fields over 1 byte long, vastly reducing the amount of ACPI modification needed (if any) for working battery status" is neither short nor concise and it's also directly copied from the EC Enabler Repo.
  2. "Any" as arch is perfectly fine. Especially in regards to compatibility. If someone would like to install a 32 bit macOS on a legacy device it wouldn't boot otherwise.

Please don't make any more pull requests!