5T33Z0 / OC-Little-Translated

ACPI Hotpatches and Guides for the OpenCore Bootmanager. Enhance and fine-tune your Hackintosh by adding devices and enabling additional features not covered in the OpenCore Install Guide. Only place that covers how to use OpenCore Legacy Patcher on PCs.
BSD 3-Clause "New" or "Revised" License
538 stars 71 forks source link

Fix Customizing_ThinkPad_Keyboard_Shortcuts.md #93

Closed xuanhung1509 closed 10 months ago

xuanhung1509 commented 10 months ago

0x71 is F15 (BRIGHTNESS_UP), and corresponds to e0 06 0x6b is F14 (BRIGHTNESS_DOWN), and corresponds to e0 05

5T33Z0 commented 10 months ago

This text is a translation from a blog post (https://blog.skk.moe/post/ssdt-map-fn-shortcuts/) where Brightness Down is 0x6b. So either your machine uses a different mapping or the error is in the original text. Since I can't test this, I won't change the text.

For understanding the principle, it really doesn't matter if it's Brightness up or down – as long as the fundamental principle is understood.

xuanhung1509 commented 10 months ago

Not my machine, I just inspected your codes see the mismatch:

// These ADB codes are for F14/F15 (works in 10.12)
#define BRIGHTNESS_DOWN         0x6b    
#define BRIGHTNESS_UP           0x71        

BRIGHTNESS_DOWN,    // e0 05 dell down
BRIGHTNESS_UP,      // e0 06 dell up

=> 0x6b = e0 05 (your F14), 0x71 = e0 06 (your F15)