search

5a1t / parrot

Automatically votes to grow with robin
53 stars 23 forks source link

Mute filter does not work on consecutive posts #109

Open carreter opened 8 years ago

carreter commented 8 years ago

If someone that is muted posts, only the first line is muted. The next lines which do not have a name attached (multiple lines in quick succession) are not muted. This is quite annoying.

For example: https://imgur.com/SBqCaE7 I did not write the highlighted text, it comes from a conversation that I tried to mute.

Maybe this could be fixed by deleting all lines after until it encounters a new username?

dashed commented 8 years ago

@palmerito0 what version?

carreter commented 8 years ago

v2.84

EDIT: I'll update and retest asap

EDIT 2: Still happens on v2.91

dashed commented 8 years ago

@palmerito0 unsure how to fix this...

dashed commented 8 years ago

@palmerito0 if you're in larger chats; this becomes a non issue...

vinnymac commented 8 years ago

@dashed if we were to solve this, it might go something like:

Given a muted message. Find the next message with a username. Mute (remove) all messages in-between muted and next including muted message.

EDIT: Nevermind, that won't work, you can't trust the order received. Just tested this myself, and other messages may come between them.