search

5afe / contract-proxy-kit

Enable batched transactions and contract account interactions using a unique deterministic Gnosis Safe.
103 stars 38 forks source link

Handle safe transaction hash returned from the web UI #110

Closed germartinez closed 4 years ago

germartinez commented 4 years ago

Check https://github.com/gnosis/contract-proxy-kit/issues/85

germartinez commented 4 years ago

@cag SafeAppsSdkConnector is instantiated in the CPK constructor. Before using Ctrl + F make sure the file CPK.ts is expanded. I will combine the returning types ;)

rmeissner commented 4 years ago

What is the breaking change? But by definition we should go with 3 🤔

germartinez commented 4 years ago

Breaking change is that execTransactions is now returning the object:

TransactionResult {
  hash?: string
  safeTxHash?: string
}

instead of:

TransactionResult {
  hash: string
}
germartinez commented 4 years ago

I'm merging this PR into development branch. Let's discuss it before merging these PRs into master branch

rmeissner commented 4 years ago

Hmm that would only happen in the safe app case so I would be fine with 2.1 too ... Up to You guys ;)