search

5afe / contract-proxy-kit

Enable batched transactions and contract account interactions using a unique deterministic Gnosis Safe.
103 stars 37 forks source link

[Discord] overflow error when sending 50$ of Wei #146

Closed sche closed 3 years ago

sche commented 3 years ago

Reported issue https://discordapp.com/channels/477106835862716416/477391201708802058/812475211869323295

Hi there, I'm getting an overflow error when using contract-proxy-kit. I'm sending a very reasonable amount of wei as the value parameter, equal to $50 USD, but contract-proxy-kit seems to be trying to force the value param to fit inside of a Number causing an overflow: https://github.com/gnosis/contract-proxy-kit/blob/v2.1.0/src/utils/transactions.ts#L72

it seems the error comes from value >= MAX_SAFE inside bignumber.js

germartinez commented 3 years ago

This is a known issue. The fix will be included in the new release on monday.

artsparkAI commented 3 years ago

This is a known issue. The fix will be included in the new release on monday.

Thank you for all your hard work