search

5afe / contract-proxy-kit

Enable batched transactions and contract account interactions using a unique deterministic Gnosis Safe.
103 stars 37 forks source link

ethers transactionResponse object #88

Closed gitpusha closed 3 years ago

gitpusha commented 4 years ago

Hi,

When using the cpk the ethers transactionResponse obj seems to be modified and looks like this:

image

So the TransactionResponse is itself inserted into an Object with the only other property thereof being the hash property. But this already exists on the TransactionResponse object.

It makes the syntax a bit unnecessarily cumbersome:

const txResponse = await cpk.execTransactions(..
await txResponse.transactionResponse.wait();

instead of plain await txResponse.wait()

germartinez commented 3 years ago

This will be implemented instead: https://github.com/gnosis/contract-proxy-kit/issues/118