Closed maxsiz closed 1 year ago
Hey @maxsiz thank you for the submission!
The dApp looks good!
Could you grant me read permissions to the frontend repo to have a quick look to the implementation? this is my Gitlab user: https://gitlab.com/dasomoza
Thanks!
Hello, thank you for the update. We move it opensource https://gitlab.com/envelop/web3app_v1
MC
пн, 3 июл. 2023 г. в 18:26, Dani Somoza @.***>:
Hey @maxsiz https://github.com/maxsiz thank you for the submission!
The dApp looks good!
Could you grant me read permissions to the frontend repo https://gitlab.com/niftsy/web3app_v1 to have a quick look to the implementation?
Thanks!
— Reply to this email directly, view it on GitHub https://github.com/5afe/safe-apps-list/issues/259#issuecomment-1618007571, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEDPSB7ZMJRJCQ5OAHNSA6LXOKT67ANCNFSM6AAAAAAY4GIG5E . You are receiving this because you were mentioned.Message ID: @.***>
Hi @maxsiz
It seems that the project is not visible for me:
Hmmm
Check please, I have granted access MC
пн, 3 июл. 2023 г. в 18:49, Dani Somoza @.***>:
Hi @maxsiz https://github.com/maxsiz
It seems that the project is not visible for me:
[image: gitlab-repo-404] https://user-images.githubusercontent.com/26763673/250547182-97b9c906-757f-432a-82e1-ba06fcf77e17.jpg
— Reply to this email directly, view it on GitHub https://github.com/5afe/safe-apps-list/issues/259#issuecomment-1618066186, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEDPSB2TMFQZD4ZH5QTSI7DXOKWUNANCNFSM6AAAAAAY4GIG5E . You are receiving this because you were mentioned.Message ID: @.***>
@maxsiz Could you update old @gnosis.pm
packages to our new @safe-global
packages?
see: https://gitlab.com/envelop/web3app_v1/-/blob/master/package.json#L6
old packages:
@gnosis.pm/safe-apps-provider
@gnosis.pm/safe-apps-react-sdk
new packages:
@safe-global/safe-apps-provider
@safe-global/safe-apps-react-sdk
https://gitlab.com/envelop/web3app_v1/-/commit/ccf545fd800f6e775f18c6d715d35867f8221320
Done MC
пн, 3 июл. 2023 г. в 19:12, Dani Somoza @.***>:
Could you update old @gnosis.pm packages to our new @safe-global packages?
see: https://gitlab.com/envelop/web3app_v1/-/blob/master/package.json#L6
old packages:
@gnosis.pm/safe-apps-provider @gnosis.pm/safe-apps-react-sdk
new packages:
@safe-global/safe-apps-provider @safe-global/safe-apps-react-sdk
— Reply to this email directly, view it on GitHub https://github.com/5afe/safe-apps-list/issues/259#issuecomment-1618125078, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEDPSB4ZZYSWN7AJD57RNDTXOKZJNANCNFSM6AAAAAAY4GIG5E . You are receiving this because you were mentioned.Message ID: @.***>
Hi! QA from safe apps team here 😄 Some comments from me:
The mint feature does not look to be working as expected, always prompting to connect a wallet.
https://github.com/5afe/safe-apps-list/assets/92332710/054fce17-b0cc-4444-b56e-8fd6932f87ac
The create tickets feature does not seem to work inside of an iframe given the console error shown:
Farming and launchpad features on the top menu always seem to redirect to a new tab which will make it not compatible with a safe. Is this expected?
Cheers!
Hi, thanks for update. Actually for starters, we would like to make available for Gnosis users only main our dapps features of the protocol.
Other features(in fact separate applications) not adopted for Gnosis right now
I understand but what worries me is that this will be quite tricky for our users. Even if those two are compatible, the rest that are not will be easily accesible from the app too.
Just let us make new build to solve this issue. I will ping you when done
Okay
Could you please check with this URI
https://app.envelop.is
Much nicer now, thank you! Note that minting does still not work:
https://github.com/5afe/safe-apps-list/assets/92332710/48021047-0671-4bae-893a-a5b2cf8cc0e7
Could you please clear cash because it workin for me
You are right, my bad. All good with the app now, we will let the team know for a final 👀 and we will post a confirmation message here once the app is listed.
Cheers!
Hello @maxsiz! The app has been published
Could you please add our dapp for Arbitrum also?
Should be available now
Revision checks
Name/Description
Envelop Dapp Cross-chain multi-tool protocol providing true value to your NFT
Type
Compatible Networks
Audit document
Link to smart contracts audit: https://github.com/dao-envelop/envelop-protocol-v1/blob/master/audit/20230420_iber_envelop_audit_rev2.pdf
Code for review
Link to git repository where the app is published. https://gitlab.com/niftsy/web3app_v1
IPFS hash/App URL
https://app.envelop.is/
Team information
sourcify.dev
https://sourcify.dev/#/lookup/0x44C1bCE3f284e9a672fa4ba6f5b02E8651da88a0 https://sourcify.dev/#/lookup/0x53c55bB901812551aa36cbf022B5df35B24C9f59 https://sourcify.dev/#/lookup/0x3Ad9D520A9bF85f86C829B291870d77AF5B30697 https://sourcify.dev/#/lookup/0x27772e884e9d238F5478c07D44C515bcae585b1d https://sourcify.dev/#/lookup/0x15A623559E29C0Fc39b9561c3fD304b677E66087