Support exchange api key in header (example: apilayer.com)

5afe / safe-client-gateway

Gateway service for Safe apps that serves transaction data conforming with the UI of our mobile apps

MIT License

56 stars 87 forks source link

Support exchange api key in header (example: apilayer.com) #1107

Closed develCuy closed 1 year ago

develCuy commented 1 year ago

Make sure these boxes are checked! 📦✅

[x] You have a nightly compatible version of rustfmt installed
```
rustup component add rustfmt --toolchain nightly
```
[x] You ran cargo +nightly fmt on the code base before submitting

Reference: https://apilayer.com/marketplace/exchangerates_data-api (Tap: Documentation)

When trying to register to https://exchangeratesapi.io/ user is prompted to register at apilayer.com instead. The access_key was required in the URL but the new provider requires to pass it as apikey and as a header. Two new variables were added to .env.example as example of the new logic. The proposed change is backwards compatible.

github-actions[bot] commented 1 year ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

fernando-syslabs commented 1 year ago

I have read the CLA Document and I hereby sign the CLA

develCuy commented 1 year ago

I have read the CLA Document and I hereby sign the CLA

fmrsabino commented 1 year ago

Hey @develCuy ! Thank you for your contribution and apologies for only providing an update to this PR now.

The team was quite busy in rewriting a new version for this service which can now be found under https://github.com/safe-global/safe-client-gateway-nest.

We do not expect to provide further support on the Rust implementation right now but feel free to fork this project and run the instance with your own changes. Additionally if you feel like this should be implemented on the the implementation I'd open a new issue there for discussion.

Thank you!