5afe / safe-contracts-wrapper

MIT License
0 stars 2 forks source link

make monorepo #6

Closed n0cte closed 2 years ago

fetsorn commented 2 years ago

Dependencies should be specified in subpackages, root only needs to have lerna. Also, we need a "lerna build" and "lerna test" scripts in the root that play well with CI. And we also need a "nohoist" exception for the datetime plugin, because safe-factory-wrapper accesses it by path in node_modules.

I went ahead and added the necessary fixes, and also updated polywrap code to 0.7.0. Some of the tests are failing some of the time, I feel like that should be resolved outside this PR.

In the future if we decide to make "safe-factory-wrapper" depend on "safe-contracts-wrapper", we should avoid relative paths like "../safe-contracts-wrapper/build" and instead use yarnWorkspace hoisting by specifying "safe-contracts-wrapper: *" in package.json, and accessing a symlink in node_modules.