[Protocol Specs] Manager Upgradeability section mixes motivation and requirement

5afe / safe-core-protocol-specs

Safe{Core} Protocol is an open, modular framework to make smart accounts secure, portable, and composable.

GNU General Public License v3.0

67 stars 13 forks source link

[Protocol Specs] Manager Upgradeability section mixes motivation and requirement #33

Open mmv08 opened 1 year ago

mmv08 commented 1 year ago

The section for Manager Upgradeability mixes requirements and motivation in a single paragraph. Judging by my experience with EIPs, separating the requirement and motivation is better.

Suggestion:

Clearly define the upgradeability requirement (MUST NOT be upgradeable, MUST LOAD information from previous' version manager, etc)
Put motivation in a separate paragraph