search

5afe / safe-core-protocol-specs

Safe{Core} Protocol is an open, modular framework to make smart accounts secure, portable, and composable.
GNU General Public License v3.0
67 stars 13 forks source link

[Protocol Specs] There is no straightforward details on how to use the SignatureValidatorManager with the protocol #55

Open mmv08 opened 10 months ago

mmv08 commented 10 months ago

The specs briefly mention that the SignatureValidatorManager contract has to be enabled as a function handler in the protocol:

After a enabling a signature validator and setting SignatureValidatorManager as function handler in SafeProtocolManager

But in the detailed diagram above that section, this step is skipped

rmeissner commented 10 months ago

I would not separate these two components. They should be transparent to the user/ developers interacting with the protocol.

this is related to safe-global/safe-core-protocol#89

mmv08 commented 10 months ago

They should be transparent to the user/ developers interacting with the protocol.

Does that mean that it should be defined in the protocol's implementation docs?

Does the manager need to be mentioned in the specs at all in such a case?