search

5afe / safe-core-protocol-specs

Safe{Core} Protocol is an open, modular framework to make smart accounts secure, portable, and composable.
GNU General Public License v3.0
67 stars 13 forks source link

[Protocol Specs] The specs are missing the expected encoding for signature validators #56

Closed mmv08 closed 10 months ago

mmv08 commented 10 months ago

I couldn't find this section from the implementation in the specs: https://github.com/safe-global/safe-core-protocol/blob/feature-108-add-signature-validator/contracts/SignatureValidatorManager.sol#L95-L118

This should be mentioned in the specifications

rmeissner commented 10 months ago

For me this is an implementation detail, that is not necessarily related to the spec. As in the spec it just says "the protocol can handle this", while in the implementation we potentially use multiple contracts with internal routing to handle this.

mmv08 commented 10 months ago

Understood, so this should be added to the core-protocol docs