5afe / safe-landing-page

Deprecated, new repo – https://github.com/safe-global/safe-homepage

MIT License

3 stars 7 forks source link

feat: add careers page #35

Closed DiogoSoaress closed 2 years ago

DiogoSoaress commented 2 years ago

Feature branch to be QAd

Todos:

[x] Benefits component
[x] TeamMember card component
[x] Job Positions card component
[x] Location component
[x] fetch the API (https://boards-api.greenhouse.io/v1/boards/gnosis/jobs)
[x] Integration in the layout

Check before merge

[x] Extract the media query constant
[x] Add social media links for each team member

Figma reference

Screenshot

localhost_8000_careers (2)

github-actions[bot] commented 2 years ago

CLA Assistant Lite All Contributors have signed the CLA.

katspaugh commented 2 years ago

The page is looking is really good already 💪

The Github link should be https://github.com/safe-global, not https://github.com/gnosis?utf8=%E2%9C%93&q=safe

DiogoSoaress commented 2 years ago

Can you bring the leaders images down a bit so their heads aren't cut off?

I think we'd need different assets for that, the assets we are using really have the top cutting over the heads 😬

DiogoSoaress commented 2 years ago

Can you bring the leaders images down a bit so their heads aren't cut off?

I asked HR for new resources. If they are provided let's change these images. Otherwise this design mirrors https://www.figma.com/file/22Zq3F3KfVtCq86tKZ0ZwI/Careers?node-id=0%3A1 where the heads are also cut off.

Not a big deal I'd say but I will update it if we get new assets 👌

JagoFigueroa commented 2 years ago

Hola gentlemen! All good from my side. The careers page is looking fresh and working as expected on different browsers, resolutions & dimensions.

Un abrazo ;)

JagoFigueroa commented 2 years ago

A small note that I just noticed on a bigger resolution screen (2k):

Screenshot 2022-05-02 at 13 45 47

The grey decoration overlaps a tiny bit with the photos. Seems kind of trivial but in case you would like to change this. My approval persists :)

DiogoSoaress commented 2 years ago

A small note that I just noticed on a bigger resolution screen (2k):

The grey decoration overlaps a tiny bit with the photos. Seems kind of trivial but in case you would like to change this. My approval persists :)

We were just looking at it here in a 2K screen and we decide to go with it. Looking at the whole page it does not feel wrong :)

germartinez commented 2 years ago

There is an horizontal scrollbar issue (caused by the top menu) for screens that meet the following condition: 980px < screenWidth < ~1070px