search

5afe / safe-landing-page

Deprecated, new repo – https://github.com/safe-global/safe-homepage
MIT License
3 stars 7 forks source link

feat: Add header section for careers page #40

Closed usame-algan closed 2 years ago

usame-algan commented 2 years ago

What it solves

Adds a header section to the careers page

Screenshot

Screenshot 2022-04-27 at 12 50 29

github-actions[bot] commented 2 years ago

CLA Assistant Lite All Contributors have signed the CLA.

iamacook commented 2 years ago

The flow is a bit strange with # Positions above Join us. I would move it below the header. Maybe you could even move the number onto the button.

usame-algan commented 2 years ago

The flow is a bit strange with # Positions above Join us. I would move it below the header. Maybe you could even move the number onto the button.

I followed the Design but like the idea of displaying the number of open positions within the button instead of above the title.

katspaugh commented 2 years ago

So the header from other pages isn't reusable after all?

usame-algan commented 2 years ago

So the header from other pages isn't reusable after all?

Unfortunately, there are no "central" styled components that we can reuse. This can definitely be refactored together with adjustments for typography and spacings but I would suggest to do it in a separate task.