5afe / safe-react

Deprecated! New repo – https://github.com/safe-global/web-core
MIT License
332 stars 364 forks source link

Fix issues created by types refactor #1347

Closed dasanra closed 4 years ago

dasanra commented 4 years ago

After a type refactor some issues were introduced into development environment. This issues prevented from submitting a transaction and lead to an app crash when loading a safe for the first time.

Changes were removed from development and we created a new branch in order to debug and fix this two issues before adding this refactor again

francovenica commented 4 years ago

Tried different type of tx in dev, making sure it works now and doesn't crash the site

Tried with MM extension, MM via WalletConnect, Trezor, Ledger.

Didn't had any issues. It looks good to me